Merge pull request #3704 from ilandikov/fix/toggling-query-file-defaults

fix: toggling query file defaults can show and hide fields again

Author: claremacrae

src/Renderer/HtmlQueryResultsRenderer.ts

@@ -28,7 +28,7 @@ export class HtmlQueryResultsRenderer extends QueryResultsRendererBase {
     protected readonly obsidianComponent: Component | null;
     protected readonly obsidianApp: App;
 
-    private readonly taskLineRenderer: TaskLineRenderer;
+    private taskLineRenderer: TaskLineRenderer;
 
     // document.createElement() creates dummy elements that must be overwritten later
     // with the values of elements that will be rendered
@@ -60,7 +60,11 @@ export class HtmlQueryResultsRenderer extends QueryResultsRendererBase {
         this.textRenderer = textRenderer;
         this.queryRendererParameters = queryRendererParameters;
 
-        this.taskLineRenderer = new TaskLineRenderer({
+        this.taskLineRenderer = this.createTaskLineRenderer();
+    }
+
+    private createTaskLineRenderer() {
+        return new TaskLineRenderer({
             textRenderer: this.textRenderer,
             obsidianApp: this.obsidianApp,
             obsidianComponent: this.obsidianComponent,
@@ -70,7 +74,7 @@ export class HtmlQueryResultsRenderer extends QueryResultsRendererBase {
     }
 
     protected beginRender(): void {
-        return;
+        this.taskLineRenderer = this.createTaskLineRenderer();
     }
 
     protected renderSearchResultsHeader(_queryResult: QueryResult): void {

tests/Renderer/QueryResultsRenderer.test.QueryResultsRenderer_-_sequences_global_query_change_to_query_layout_option.approved.html

@@ -13,18 +13,12 @@ <h2>Initial results:</h2>
     <button test-icon="lucide-copy" test-tooltip="Copy results"></button>
   </div>
   <pre class="plugin-tasks-query-explanation">
-Explanation of the global query:
-
-  No filters supplied. All tasks will match the query.
-
-  hide due date
-
 Explanation of this Tasks code block query:
 
   No filters supplied. All tasks will match the query.
 </pre
   >
-  <ul class="contains-task-list plugin-tasks-query-result tasks-layout-hide-dueDate tasks-layout-hide-urgency">
+  <ul class="contains-task-list plugin-tasks-query-result tasks-layout-hide-urgency">
     <li
       class="task-list-item plugin-tasks-list-item"
       data-task-due="today"
@@ -36,6 +30,9 @@ <h2>Initial results:</h2>
       <input class="task-list-item-checkbox" type="checkbox" data-line="0" />
       <span class="tasks-list-text">
         <span class="task-description"><span>parent</span></span>
+        <span class="task-due" data-task-due="today" title="Click to edit due date, Right-click for more options">
+          <span>📅 2025-12-01</span>
+        </span>
       </span>
       <span class="task-extras">
         <span class="tasks-backlink">
@@ -109,6 +106,9 @@ <h2>Check that urgency is shown by global query:</h2>
       <input class="task-list-item-checkbox" type="checkbox" data-line="0" />
       <span class="tasks-list-text">
         <span class="task-description"><span>parent</span></span>
+        <span class="task-due" data-task-due="today" title="Click to edit due date, Right-click for more options">
+          <span>📅 2025-12-01</span>
+        </span>
       </span>
       <span class="task-extras">
         <span class="tasks-urgency">10.75</span>

tests/Renderer/QueryResultsRenderer.test.QueryResultsRenderer_-_sequences_global_query_change_to_task_layout_option.approved.html

@@ -106,9 +106,6 @@ <h2>Check that due date is hidden by global query:</h2>
       <input class="task-list-item-checkbox" type="checkbox" data-line="0" />
       <span class="tasks-list-text">
         <span class="task-description"><span>parent</span></span>
-        <span class="task-due" data-task-due="today" title="Click to edit due date, Right-click for more options">
-          <span>📅 2025-12-01</span>
-        </span>
       </span>
       <span class="task-extras">
         <span class="tasks-backlink">

tests/Renderer/QueryResultsRenderer.test.ts

@@ -28,6 +28,7 @@ beforeEach(() => {
 afterEach(() => {
     jest.useRealTimers();
     resetSettings();
+    GlobalQuery.getInstance().reset();
 });
 
 function makeQueryResultsRenderer(source: string, tasksFile: TasksFile, allTasks: Task[]) {
@@ -135,9 +136,9 @@ class RendererStoryboard {
 describe('QueryResultsRenderer - sequences', () => {
     const parent = new TaskBuilder().description('parent').dueDate('2025-12-01').build();
     const child = new TaskBuilder().description('child').indentation('  ').id('childID').parent(parent).build();
-    const parentAndChild: Task[] = [parent, child];
+    const parentAndChild = [parent, child];
 
-    it.failing('global query change to task layout option', async () => {
+    it('global query change to task layout option', async () => {
         // see issue #3702
         const source = 'explain';
         const storyboard = new RendererStoryboard(source, parentAndChild);
@@ -160,7 +161,6 @@ describe('QueryResultsRenderer - sequences', () => {
     });
 
     it('global query change to query layout option', async () => {
-        // see issue #3702
         const source = 'explain';
         const storyboard = new RendererStoryboard(source, parentAndChild);
         const urgency = '<span class="tasks-urgency">10.75</span>';