Skip to content

Commit 7f13ce7

Browse files
committed
refactor: - call addChildren() in base class
1 parent 2b85d58 commit 7f13ce7

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

src/Renderer/HtmlQueryResultsRenderer.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -137,15 +137,13 @@ export class HtmlQueryResultsRenderer extends QueryResultsRendererBase {
137137
this.liElementStack.push(listItemElement);
138138
}
139139

140-
protected async addListItem(listItem: ListItem, listItemIndex: number, children: ListItem[]): Promise<void> {
140+
protected async addListItem(listItem: ListItem, listItemIndex: number, _children: ListItem[]): Promise<void> {
141141
const listItemElement = this.currentLIElement();
142142

143143
await this.taskLineRenderer.renderListItem(listItemElement, listItem, listItemIndex);
144-
145-
await this.addChildren(children);
146144
}
147145

148-
protected async addTask(task: Task, taskIndex: number, children: ListItem[]): Promise<void> {
146+
protected async addTask(task: Task, taskIndex: number, _children: ListItem[]): Promise<void> {
149147
const isFilenameUnique = this.isFilenameUnique({ task }, this.queryRendererParameters.allMarkdownFiles());
150148
const listItem = this.currentLIElement();
151149

@@ -183,8 +181,6 @@ export class HtmlQueryResultsRenderer extends QueryResultsRendererBase {
183181
}
184182

185183
this.currentULElement().appendChild(listItem);
186-
187-
await this.addChildren(children);
188184
}
189185

190186
protected async addChildren(children: ListItem[]) {

src/Renderer/QueryResultsRendererBase.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,8 @@ export abstract class QueryResultsRendererBase {
188188
await this.addListItem(listItem, listItemIndex, listItem.children);
189189
}
190190

191+
await this.addChildren(listItem.children);
192+
191193
// The children of this item will be added thanks to recursion and the fact that we always render all children currently
192194
this.addedListItems.add(listItem);
193195

0 commit comments

Comments
 (0)