refactor: - Manually inline findClosestParentTask() in ListItem.ts

Author: claremacrae

src/Task/ListItem.ts

@@ -47,8 +47,22 @@ export class ListItem {
         return this.parent === null;
     }
 
+    /**
+     * Find to find the closest parent that is a {@link Task}
+     */
     public findClosestParentTask(): Task | null {
-        return findClosestParentTask(this);
+        let closestParentTask = this.parent;
+
+        while (closestParentTask !== null) {
+            // Lazy load the Task class to avoid circular dependencies
+            const { Task } = require('./Task');
+            if (closestParentTask instanceof Task) {
+                return closestParentTask as Task;
+            }
+            closestParentTask = closestParentTask.parent;
+        }
+
+        return null;
     }
 
     get isTask() {
@@ -97,27 +111,3 @@ export class ListItem {
         return list1.every((item, index) => item.identicalTo(list2[index]));
     }
 }
-
-/**
- * We want this function to be a method of ListItem but that causes a circular dependency
- * which makes the plugin fail to load in Obsidian.
- *
- * Note: the tests are in ListItem.test.ts
- *
- * @param listItem
- */
-export function findClosestParentTask(listItem: ListItem): Task | null {
-    // Try to find the closest parent that is a task
-    let closestParentTask = listItem.parent;
-
-    while (closestParentTask !== null) {
-        // Lazy load the Task class to avoid circular dependencies
-        const { Task } = require('./Task');
-        if (closestParentTask instanceof Task) {
-            return closestParentTask as Task;
-        }
-        closestParentTask = closestParentTask.parent;
-    }
-
-    return null;
-}