Merge pull request #3563 from obsidian-tasks-group/fix-issue-3546-ipad-iphone-parsing-broken

fix: Enable new iPad/iPhone OS versions to read Emoji tasks (#3546,#3560)

Author: claremacrae

src/TaskSerializer/DefaultTaskSerializer.ts

@@ -67,7 +67,7 @@ function fieldRegex(symbols: string, valueRegexString: string) {
     // The regexes end with `$` because they will be matched and
     // removed from the end until none are left.
     source += '$';
-    return new RegExp(source, 'u');
+    return new RegExp(source); // Remove the 'u' flag, to fix parsing on iPadOS/iOS 18.6 and 26 Public Beta 2
 }
 
 /**
@@ -95,11 +95,11 @@ export const DEFAULT_SYMBOLS: DefaultTaskSerializerSymbols = {
     dependsOnSymbol: '⛔',
     idSymbol: '🆔',
     TaskFormatRegularExpressions: {
-        priorityRegex: fieldRegex('([🔺⏫🔼🔽⏬])', ''),
+        priorityRegex: fieldRegex('(🔺|⏫|🔼|🔽|⏬)', ''),
         startDateRegex: dateFieldRegex('🛫'),
         createdDateRegex: dateFieldRegex('➕'),
-        scheduledDateRegex: dateFieldRegex('[⏳⌛]'),
-        dueDateRegex: dateFieldRegex('[📅📆🗓]'),
+        scheduledDateRegex: dateFieldRegex('(?:⏳|⌛)'),
+        dueDateRegex: dateFieldRegex('(?:📅|📆|🗓)'),
         doneDateRegex: dateFieldRegex('✅'),
         cancelledDateRegex: dateFieldRegex('❌'),
         recurrenceRegex: fieldRegex('🔁', '([a-zA-Z0-9, !]+)'),

tests/TaskSerializer/DefaultTaskSerializer.test.ts

@@ -65,17 +65,17 @@ describe('validate emoji regular expressions', () => {
     it('regular expressions should have expected source', () => {
         expect(generateRegexApprovalTest()).toMatchInlineSnapshot(`
             "
-            priorityRegex: /([🔺⏫🔼🔽⏬])\\ufe0f?$/u
-            startDateRegex: /🛫\\ufe0f? *(\\d{4}-\\d{2}-\\d{2})$/u
-            createdDateRegex: /➕\\ufe0f? *(\\d{4}-\\d{2}-\\d{2})$/u
-            scheduledDateRegex: /[⏳⌛]\\ufe0f? *(\\d{4}-\\d{2}-\\d{2})$/u
-            dueDateRegex: /[📅📆🗓]\\ufe0f? *(\\d{4}-\\d{2}-\\d{2})$/u
-            doneDateRegex: /✅\\ufe0f? *(\\d{4}-\\d{2}-\\d{2})$/u
-            cancelledDateRegex: /❌\\ufe0f? *(\\d{4}-\\d{2}-\\d{2})$/u
-            recurrenceRegex: /🔁\\ufe0f? *([a-zA-Z0-9, !]+)$/u
-            onCompletionRegex: /🏁\\ufe0f? *([a-zA-Z]+)$/u
-            dependsOnRegex: /⛔\\ufe0f? *([a-zA-Z0-9-_]+( *, *[a-zA-Z0-9-_]+ *)*)$/u
-            idRegex: /🆔\\ufe0f? *([a-zA-Z0-9-_]+)$/u
+            priorityRegex: /(🔺|⏫|🔼|🔽|⏬)\\ufe0f?$/
+            startDateRegex: /🛫\\ufe0f? *(\\d{4}-\\d{2}-\\d{2})$/
+            createdDateRegex: /➕\\ufe0f? *(\\d{4}-\\d{2}-\\d{2})$/
+            scheduledDateRegex: /(?:⏳|⌛)\\ufe0f? *(\\d{4}-\\d{2}-\\d{2})$/
+            dueDateRegex: /(?:📅|📆|🗓)\\ufe0f? *(\\d{4}-\\d{2}-\\d{2})$/
+            doneDateRegex: /✅\\ufe0f? *(\\d{4}-\\d{2}-\\d{2})$/
+            cancelledDateRegex: /❌\\ufe0f? *(\\d{4}-\\d{2}-\\d{2})$/
+            recurrenceRegex: /🔁\\ufe0f? *([a-zA-Z0-9, !]+)$/
+            onCompletionRegex: /🏁\\ufe0f? *([a-zA-Z]+)$/
+            dependsOnRegex: /⛔\\ufe0f? *([a-zA-Z0-9-_]+( *, *[a-zA-Z0-9-_]+ *)*)$/
+            idRegex: /🆔\\ufe0f? *([a-zA-Z0-9-_]+)$/
             "
         `);
     });