test: - Reuse createChildListItem() to silence SonarCloud warning: typescript:S1848

Author: claremacrae

tests/Task/ListItem.test.ts

@@ -115,7 +115,7 @@ describe('identicalTo', () => {
 
     it('should recognise list items with different number of children', () => {
         const item1 = new ListItem('- item', null);
-        new ListItem('- child of item1', item1);
+        createChildListItem('- child of item1', item1);
 
         const item2 = new ListItem('- item', null);
 
@@ -127,7 +127,7 @@ describe('identicalTo', () => {
         createChildListItem('- child of item1', item1);
 
         const item2 = new ListItem('- item', null);
-        new ListItem('- child of item2', item2);
+        createChildListItem('- child of item2', item2);
 
         expect(item2.identicalTo(item1)).toEqual(false);
     });

tests/Task/Task.test.ts

@@ -5,7 +5,6 @@ import moment from 'moment';
 import { verifyAll } from 'approvals/lib/Providers/Jest/JestApprovals';
 import { TasksFile } from '../../src/Scripting/TasksFile';
 import { Status } from '../../src/Statuses/Status';
-import { ListItem } from '../../src/Task/ListItem';
 import { Task } from '../../src/Task/Task';
 import { resetSettings, updateSettings } from '../../src/Config/Settings';
 import { GlobalFilter } from '../../src/Config/GlobalFilter';
@@ -23,6 +22,7 @@ import type { TasksDate } from '../../src/DateTime/TasksDate';
 import { example_kanban } from '../Obsidian/__test_data__/example_kanban';
 import { jason_properties } from '../Obsidian/__test_data__/jason_properties';
 import { OnCompletion } from '../../src/Task/OnCompletion';
+import { createChildListItem } from './ListItemHelpers';
 
 window.moment = moment;
 
@@ -1735,16 +1735,16 @@ describe('identicalTo', () => {
     it('should recognise different numbers of child items', () => {
         const task1 = new TaskBuilder().build();
         const task2 = new TaskBuilder().build();
-        new ListItem('- child of task2', task2);
+        createChildListItem('- child of task2', task2);
 
         expect(task2.identicalTo(task1)).toEqual(false);
     });
 
     it('should recognise different description in child list items', () => {
         const task1 = new TaskBuilder().build();
         const task2 = new TaskBuilder().build();
-        new ListItem('- child of task1', task1);
-        new ListItem('- child of task2', task2);
+        createChildListItem('- child of task1', task1);
+        createChildListItem('- child of task2', task2);
 
         expect(task2.identicalTo(task1)).toEqual(false);
     });