fix: Make 'Tasks: Toggle task done' convert non-list-items straight to checklists (#1158)

This is for consistency with the built-in 'Toggle checkbox status' command.

Fixes #1158.

Author: claremacrae

src/Commands/ToggleDone.ts

@@ -108,8 +108,8 @@ export const toggleLine = (line: string, path: string): EditorInsertion => {
             const text = line.replace(TaskRegularExpressions.listItemRegex, '$1$2 [ ]');
             return { text, moveTo: { ch: text.length } };
         } else {
-            // Convert the line to a list item.
-            const text = line.replace(TaskRegularExpressions.indentationRegex, '$1- ');
+            // Convert the line to a checklist item.
+            const text = line.replace(TaskRegularExpressions.indentationRegex, '$1- [ ] ');
             return { text, moveTo: { ch: text.length } };
         }
     }

tests/Commands/ToggleDone.test.ts

@@ -93,14 +93,14 @@ describe('ToggleDone', () => {
     // Most of the tests are run twice. The second time, they are tested with tasks that
     // do not match the global filter.
 
-    it('should add hyphen and space to empty line', () => {
-        testToggleLine('|', '- |');
-        testToggleLine('foo|bar', '- foobar|');
+    it('should add checkbox to empty line, and lines without list items', () => {
+        testToggleLine('|', '- [ ] |');
+        testToggleLine('foo|bar', '- [ ] foobar|');
 
         GlobalFilter.getInstance().set('#task');
 
-        testToggleLine('|', '- |');
-        testToggleLine('foo|bar', '- foobar|');
+        testToggleLine('|', '- [ ] |');
+        testToggleLine('foo|bar', '- [ ] foobar|');
     });
 
     it('should add checkbox to hyphen and space', () => {