refactor: ! Remove activeFlatpickrInstance from EditTask

Tested use of Escape key manually, with just Modal open, and with native date-picker open

Author: claremacrae

src/Obsidian/TaskModal.ts

@@ -1,5 +1,4 @@
 import { App, Modal } from 'obsidian';
-import type flatpickr from 'flatpickr';
 
 import EditTask from '../ui/EditTask.svelte';
 import type { Task } from '../Task/Task';
@@ -10,7 +9,6 @@ export class TaskModal extends Modal {
     public readonly task: Task;
     public readonly onSubmit: (updatedTasks: Task[]) => void;
     public readonly allTasks: Task[];
-    private activeFlatpickrInstance: flatpickr.Instance | null = null;
 
     constructor({
         app,
@@ -28,13 +26,6 @@ export class TaskModal extends Modal {
         this.task = task;
         this.allTasks = allTasks;
         this.onSubmit = (updatedTasks: Task[]) => {
-            if (this.activeFlatpickrInstance) {
-                // Ignore onSubmit if the date-picker is open:
-                // For some unknown reason, making the date-picker lunched from a Button
-                // caused the modal to be automatically submitted before the user had
-                // even seen the date picker.
-                return;
-            }
             updatedTasks.length && onSubmit(updatedTasks);
             this.close();
         };
@@ -78,17 +69,4 @@ export class TaskModal extends Modal {
         const { contentEl } = this;
         contentEl.empty();
     }
-
-    /**
-     * Make sure that if the date picker is open, an Escape key only closes
-     * the date-picker, and not the EditTask modal as well.
-     */
-    public onEscapeKey(): void {
-        if (this.activeFlatpickrInstance?.isOpen) {
-            this.activeFlatpickrInstance.close();
-            this.activeFlatpickrInstance = null;
-        } else {
-            this.close();
-        }
-    }
 }