Skip to content

Commit d43e3a4

Browse files
authored
Merge pull request #3511 from obsidian-tasks-group/fix-preset-select
fix: Allow text selection with mouse in Preset settings
2 parents 380417f + 2a1911e commit d43e3a4

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/Config/PresetsSettingsUI.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,6 @@ export class PresetsSettingsUI {
7171
const setting = new Setting(wrapper);
7272
setting.settingEl.addClass('tasks-presets-setting');
7373

74-
// Make the wrapper draggable
75-
wrapper.draggable = true;
7674
wrapper.setAttribute('data-preset-key', key);
7775

7876
// Add name input field
@@ -131,6 +129,8 @@ export class PresetsSettingsUI {
131129

132130
btn.extraSettingsEl.style.cursor = 'grab';
133131
btn.extraSettingsEl.addEventListener('mousedown', (_e) => {
132+
// Enable dragging only when mousedown starts on the handle
133+
wrapper.draggable = true;
134134
btn.extraSettingsEl.style.cursor = 'grabbing';
135135
});
136136
btn.extraSettingsEl.addEventListener('mouseup', (_e) => {
@@ -181,6 +181,8 @@ export class PresetsSettingsUI {
181181

182182
// Drag end
183183
wrapper.addEventListener('dragend', (_e) => {
184+
// Disable dragging after drag ends
185+
wrapper.draggable = false;
184186
wrapper.removeClass('tasks-presets-dragging');
185187
this.clearDropIndicators();
186188
});

0 commit comments

Comments
 (0)