refactor: Remove Link.filenameContainingLink - pathContainingLink is now used instead

Author: claremacrae

src/Scripting/TasksFile.ts

@@ -61,20 +61,14 @@ export class TasksFile {
      * Return an array of {@link Link} in the file's properties/frontmatter.
      */
     get outlinksInProperties(): Link[] {
-        return (
-            this.cachedMetadata.frontmatterLinks?.map(
-                (link) => new Link(link, this.filenameWithoutExtension, this.path),
-            ) ?? []
-        );
+        return this.cachedMetadata.frontmatterLinks?.map((link) => new Link(link, this.path)) ?? [];
     }
 
     /**
      * Return an array of {@link Link} in the body of the file.
      */
     get outlinksInBody(): Link[] {
-        return (
-            this.cachedMetadata?.links?.map((link) => new Link(link, this.filenameWithoutExtension, this.path)) ?? []
-        );
+        return this.cachedMetadata?.links?.map((link) => new Link(link, this.path)) ?? [];
     }
 
     /**

src/Task/Link.ts

@@ -2,18 +2,14 @@ import type { Reference } from 'obsidian';
 
 export class Link {
     private readonly rawLink: Reference;
-    // @ts-expect-error: TS6133: filenameContainingLink is declared but its value is never read.
-    private readonly filenameContainingLink: string;
     private readonly pathContainingLink: string;
 
     /**
      * @param {Reference} rawLink - The raw link from Obsidian cache.
-     * @param {string} filenameContainingLink - The name of the file where this link is located.
      * @param {string} pathContainingLink - The path of the file where this link is located.
      */
-    constructor(rawLink: Reference, filenameContainingLink: string, pathContainingLink: string) {
+    constructor(rawLink: Reference, pathContainingLink: string) {
         this.rawLink = rawLink;
-        this.filenameContainingLink = filenameContainingLink;
         this.pathContainingLink = pathContainingLink;
     }
 

src/Task/ListItem.ts

@@ -210,7 +210,7 @@ export class ListItem {
     public get outlinks(): Link[] {
         return this.rawLinksInFileBody
             .filter((link) => link.position.start.line === this.lineNumber)
-            .map((link) => new Link(link, this.file.filenameWithoutExtension, this.file.path));
+            .map((link) => new Link(link, this.file.path));
     }
 
     /**

tests/Task/Link.test.ts

@@ -1,5 +1,4 @@
 import { Link } from '../../src/Task/Link';
-import { TasksFile } from '../../src/Scripting/TasksFile';
 
 import links_everywhere from '../Obsidian/__test_data__/links_everywhere.json';
 import internal_heading_links from '../Obsidian/__test_data__/internal_heading_links.json';
@@ -13,7 +12,7 @@ import type { SimulatedFile } from '../Obsidian/SimulatedFile';
 
 function getLink(data: any, index: number) {
     const rawLink = data.cachedMetadata.links[index];
-    return new Link(rawLink, new TasksFile(data.filePath).filenameWithoutExtension, data.filePath);
+    return new Link(rawLink, data.filePath);
 }
 
 describe('linkClass', () => {