Skip to content

Commit e3febc7

Browse files
refactor: - Make 3 methods private in base class
Co-Authored-By: Ilyas Landikov <[email protected]>
1 parent 5d8bd63 commit e3febc7

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

src/Renderer/QueryResultsRendererBase.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -189,8 +189,7 @@ export abstract class QueryResultsRendererBase {
189189
}
190190
}
191191

192-
// TODO make private
193-
protected willBeAddedLater(listItem: ListItem, listItems: ListItem[]) {
192+
private willBeAddedLater(listItem: ListItem, listItems: ListItem[]) {
194193
const closestParentTask = listItem.findClosestParentTask();
195194
if (!closestParentTask) {
196195
return false;
@@ -207,8 +206,7 @@ export abstract class QueryResultsRendererBase {
207206
return false;
208207
}
209208

210-
// TODO make private
211-
protected alreadyAdded(listItem: ListItem) {
209+
private alreadyAdded(listItem: ListItem) {
212210
return this.addedListItems.has(listItem);
213211
}
214212

@@ -222,8 +220,7 @@ export abstract class QueryResultsRendererBase {
222220
* in which case no headings will be added.
223221
* @private
224222
*/
225-
// TODO make private
226-
protected async addGroupHeadings(groupHeadings: GroupDisplayHeading[]) {
223+
private async addGroupHeadings(groupHeadings: GroupDisplayHeading[]) {
227224
for (const heading of groupHeadings) {
228225
await this.addGroupHeading(heading);
229226
}

0 commit comments

Comments
 (0)