resolved: [internal] Is the bump for dep moment (#785) blocked by anything besides itself? #826
Replies: 5 comments 9 replies
-
|
Hi @AnnaKornfeldSimpson I think I mentioned recently that updating any dependencies was blocked on my having time to test Tasks with the new dependencies before doing the merge... So if you had time to try out each of the updates, and confirm that they worked, then I would happily go ahead and merge them. I'm curious, what is the particular appeal of the moment update? |
Beta Was this translation helpful? Give feedback.
-
|
@claremacrae Having investigated this, the bump for moment (2.29.1->2.29.3) is dependent on at least one other dep bump. I was able to reproduce the errors from the dependabot PR (#785) when I just updated moment independently. One clear tie is that obsidian (which is pinned to a specific exact version number in package.json, not even a |
Beta Was this translation helpful? Give feedback.
-
|
Hi @AnnaKornfeldSimpson Are you interested in pairing on dependencies at some point? It would be a rather higher bandwidth communication mechanism! If yes, my email is in my GitHub profile. |
Beta Was this translation helpful? Give feedback.
-
|
It is the testing part I am not sure about. I made the minimal change to package.json and am currently running the GitHub Actions tests on my fork (after figuring out the bug behind #832 since my machine was failing a test even before making any changes, which blocked me from pushing from that machine!). What is your current test process beyond the automated ones? Are there certain things you try with the test vault? Given that public obsidian is on 0.14.15 (which corresponds to obsidian API 0.14.8 I think), and insiders are already on 0.15.*, I'm not sure how many people a bump of the API to something that's still behind would affect. However, I also have no intuition about how these bundled plugins using an older version of the API than the actual obsidian program would work at all! |
Beta Was this translation helpful? Give feedback.
-
|
Ah you sent a second message while I was typing! Yes, I'll put sending you an email on my Tasks list 😁 , but I won't get to figuring out my upcoming calendar until tomorrow or Monday your time. |
Beta Was this translation helpful? Give feedback.
-
|
@claremacrae Ack, my schedule has been very unpredictable and that continues for the next week at least, but I don't want to lose track of this! My fork has my almost-minimal PR for the moment & obsidian dep bump which does pass all the automated checks. (Almost-minimal because I needed to do something about #832 in order to push at all, which is why the PR is still on my fork and not here. Not intending that change to be part of this PR.) |
Beta Was this translation helpful? Give feedback.
-
No problem at all!
The existing automated tests cover the logic of algorithms in the implementation of Tasks, but they don't cover things like rendering and user interface. In these kinds of situations, I tend to think of documenting some basic smoke tests of some core functionality - the kind of things that it would be very embarrassing and very obvious if they did not work. I would make it a checklist - probably somewhere in the demo vault, including steps to execute, and screenshots of the expected appearance. https://en.wikipedia.org/wiki/Smoke_testing_(software)
There is this community talk: it's much more aimed at getting plugin developers even starting thinking about writing any kinds of automated tests at all... It's very basic, as I was really constrained by the amount of time available for the talk itself... Maximum 1 hour. After I did the talk, there as a bit of conversation, and a thread |
Beta Was this translation helpful? Give feedback.
-
|
Pulling out of the end of the thread above: @claremacrae said:
This sounds very reasonable, but also somewhat like a separate issue/PR (whose merge could be a prerequisite for this one). E.g. can we just test the current stable version of Obsidian app or would we need to test others too? How many OS/platforms are sufficient for basic smoke test? (I read somewhere on the Obsidian forums that old Android devices with are the reason plugins have to be build-targeted to such old "target" and "lib" versions. Is that relevant for smoke testing an obsidian API bump? I have no idea!) I'm absolutely willing to help with the creation of the smoke test checklist, but this is not something that I feel capable of leading or doing independently. I can commit to executing whatever checklist is collaboratively made on this deps bump PR. At least for the (very small) set of devices/platforms I have access to. I also have some extremely novice questions (perhaps too novice even for the checklist) like "will opening a second vault (the demo vault) on my computer mess with any of my Obsidian settings?" or "how even would I download and open the demo vault on Android because Obsidian's interaction with the filesystem seems complicated"? Perhaps these are already documented in the demo vault or somewhere - if so, my apologies and please point me at links! |
Beta Was this translation helpful? Give feedback.
-
|
Hi @AnnaKornfeldSimpson - these are all really good questions. Some I could answer right now, and some not without more thought. I'm busy all day today, so no time for now - will reply soon - but if you find some space to pair, even better would be for us to discuss them and then write down our conclusions... No pressure though, 'onest! |
Beta Was this translation helpful? Give feedback.
-
|
Understood/agreed! I'm thinking it might be worthwhile to put your reply in a separate issue or discussion (I didn't know which to do here or I would have started it myself) so folks reading about smoke testing in the future don't have so many posts to read? |
Beta Was this translation helpful? Give feedback.
-
No.
I'm not sure if you can. But I wouldn't worry about Android for smoke testing. One desktop platform is fine. |
Beta Was this translation helpful? Give feedback.
-
|
Please see #858 for first draft of smoke tests. I hope they help. Feedback very gratefully received! |
Beta Was this translation helpful? Give feedback.
-
|
I believe that this is all resolved now... |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Posting this here so as not to confuse dependabot. Is #785 blocked on anything besides itself? I would really like to see that go through soon, so I was thinking about taking a look at the errors. Does it make sense to tackle #785 independently or is it blocked/depending on things someone else is already tackling? Thanks!
Beta Was this translation helpful? Give feedback.
All reactions