Skip to content

fix: Results filter now re-applied when settings or tasks edited #3706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
claremacrae merged 18 commits into from
Dec 4, 2025
Merged

fix: Results filter now re-applied when settings or tasks edited #3706

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
99158c6
test: - addFrame() returns an object
ilandikov Dec 4, 2025
e5611a5
test: - add test showing filter is lost when results are redrawn
ilandikov Dec 4, 2025
7a405f8
test: - extract prettifyContainer()
ilandikov Dec 4, 2025
70bb44b
test: add jsdoc
ilandikov Dec 4, 2025
360e005
test: - improve structure and clarity of storyboard
ilandikov Dec 4, 2025
1283075
test: - remove explain to shorten approved file
ilandikov Dec 4, 2025
298b5ba
refactor: - store filter string
ilandikov Dec 4, 2025
3e5cd8b
fix: ! keep filter text between renders
ilandikov Dec 4, 2025
46a94b2
refactor: @ remove the Notice call for invalid filters
ilandikov Dec 4, 2025
5e3c4e2
refactor: - move line up
ilandikov Dec 4, 2025
c941aac
refactor: - reuse class property
ilandikov Dec 4, 2025
5cb70cf
refactor: - move line up
ilandikov Dec 4, 2025
a498c3b
refactor: . extract filterResults()
ilandikov Dec 4, 2025
2100f86
fix: - results are filtered correctly after any edits to tasks or set…
ilandikov Dec 4, 2025
2e18e0a
refactor: . rename method to applySearchBoxFilterAndRerender()
ilandikov Dec 4, 2025
f46db1f
comment: Update a comment to clarify the current behaviour
claremacrae Dec 4, 2025
203b0f1
test: - Make the approved file self-documenting
claremacrae Dec 4, 2025
74659ff
refactor: . Prevent callers from editing QueryResultsRenderer filterS…
claremacrae Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/Renderer/QueryResultsRenderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export class QueryResultsRenderer {
protected queryType: string; // whilst there is only one query type, there is no point logging this value
public queryResult: QueryResult;
public filteredQueryResult: QueryResult;
public filterString: string = '';
private _filterString: string = '';

constructor(
className: string,
Expand Down Expand Up @@ -120,6 +120,10 @@ export class QueryResultsRenderer {
this.markdownRenderer = new MarkdownQueryResultsRenderer(getters);
}

public get filterString(): string {
return this._filterString;
}

private makeQueryFromSourceAndTasksFile() {
return getQueryForQueryRenderer(this.source, GlobalQuery.getInstance(), this.tasksFile);
}
Expand Down Expand Up @@ -192,7 +196,7 @@ export class QueryResultsRenderer {
const label = createAndAppendElement('label', toolbar);
setIcon(label, 'lucide-filter');
const searchBox = createAndAppendElement('input', label);
searchBox.value = this.filterString;
searchBox.value = this._filterString;
searchBox.placeholder = 'Filter by description...';
setTooltip(searchBox, 'Filter results');
searchBox.addEventListener('input', async () => {
Expand All @@ -202,7 +206,7 @@ export class QueryResultsRenderer {
}

public async applySearchBoxFilterAndRerender(filterString: string, content: HTMLDivElement) {
this.filterString = filterString;
this._filterString = filterString;

this.filterResults();

Expand All @@ -223,7 +227,7 @@ export class QueryResultsRenderer {

private filterResults() {
const { filter, error } = new DescriptionField().createFilterOrErrorMessage(
'description includes ' + this.filterString,
'description includes ' + this._filterString,
);
if (error) {
// If we can't create a filter, just silently show all the matching tasks
Expand Down