generated from obsidianmd/obsidian-sample-plugin
-
-
Notifications
You must be signed in to change notification settings - Fork 304
fix: Results filter now re-applied when settings or tasks edited #3706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
claremacrae
merged 18 commits into
obsidian-tasks-group:main
from
ilandikov:fix/results-filtered-correctly
Dec 4, 2025
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
99158c6
test: - addFrame() returns an object
ilandikov e5611a5
test: - add test showing filter is lost when results are redrawn
ilandikov 7a405f8
test: - extract prettifyContainer()
ilandikov 70bb44b
test: add jsdoc
ilandikov 360e005
test: - improve structure and clarity of storyboard
ilandikov 1283075
test: - remove explain to shorten approved file
ilandikov 298b5ba
refactor: - store filter string
ilandikov 3e5cd8b
fix: ! keep filter text between renders
ilandikov 46a94b2
refactor: @ remove the Notice call for invalid filters
ilandikov 5e3c4e2
refactor: - move line up
ilandikov c941aac
refactor: - reuse class property
ilandikov 5cb70cf
refactor: - move line up
ilandikov a498c3b
refactor: . extract filterResults()
ilandikov 2100f86
fix: - results are filtered correctly after any edits to tasks or set…
ilandikov 2e18e0a
refactor: . rename method to applySearchBoxFilterAndRerender()
ilandikov f46db1f
comment: Update a comment to clarify the current behaviour
claremacrae 203b0f1
test: - Make the approved file self-documenting
claremacrae 74659ff
refactor: . Prevent callers from editing QueryResultsRenderer filterS…
claremacrae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.