Skip to content

Conversation

@lc0rp
Copy link
Contributor

@lc0rp lc0rp commented Sep 8, 2025

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/lc0rp/obsidian-task-roles

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
  • I have given proper attribution to these other projects in my README.md.

@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1][2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17][18][19][20][21][22][23][24][25][26][27][28][29][30] and more :You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets.

[1][2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17][18]:You should consider limiting the number of console.logs in your code, to not pollute the dev console.


Optional

[1][2][3][4][5][6][7][8][9][10][11][12][13][14][15][16][17][18][19][20][21][22][23][24][25][26][27][28]:Casting to any should be avoided as much as possible.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Ready for review and removed Ready for review Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Sep 8, 2025
@ObsidianReviewBot ObsidianReviewBot removed their assignment Sep 8, 2025
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, ready for additional review by human.
Please be aware that it might take a few weeks before your plugin is reviewed due to the high volume of submissions currently.

@Fevol Fevol self-assigned this Nov 9, 2025
@Fevol
Copy link
Collaborator

Fevol commented Nov 9, 2025

Required Changes

Please prefix all classes (where relevant) in your styles.css so they do not conflict with other plugins.
https://github.com/lc0rp/obsidian-task-roles/blob/1c06baf76e82152be16471a6c0ec18bca49925de/styles/styles.css

Use setHeading() instead of createEl('h4', ...)

Regex:

createEl('h

You should also explicitly mention in your README that obsidian-tasks is required for enabling a particular feature of your plugin.
https://github.com/lc0rp/obsidian-task-roles/blob/1c06baf76e82152be16471a6c0ec18bca49925de/src/services/task-query.service.ts#L46

Prefer Vault.process instead of Vault.modify to modify a file in the background.
https://github.com/lc0rp/obsidian-task-roles/blob/1c06baf76e82152be16471a6c0ec18bca49925de/src/components/task-card.ts#L162

Use window.setTimeout, window.clearTimeout, window.setInterval, window.clearInterval instead of their versions without window.

Regex:

setTimeout|clearTimeout|setInterval|clearInterval

These vault listeners don't seem to get unloaded when TaskRolesService is stopped (manually or due to the plugin being disabled). You can use vault.offref(...) or register the event to a component and unload the component.
https://github.com/lc0rp/obsidian-task-roles/blob/1c06baf76e82152be16471a6c0ec18bca49925de/src/services/task-roles.service.ts#L47-L50


Optional Feedback

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants