Attribute Error

[Ariancarlos]

I am no coder, no programmer, nor have idea what the next thing means, but since it asked so nicely I'll send it here:

Traceback (most recent call last):
File "/storage/emulated/0/Download/KH.py", line 681, in
sys.exit(doIt())
^^^^^^
File "/storage/emulated/0/Download/KH.py", line 628, in doIt
success = download(soundtrack, outPath, formatOrder=formatOrder, verbose=True)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/storage/emulated/0/Download/KH.py", line 453, in download
soundtrack.name # To conistently always load the content in advance.
^^^^^^^^^^^^^^^
File "/storage/emulated/0/Download/KH.py", line 160, in lazyVersion
setattr(self, attrName, func(self))
^^^^^^^^^^
File "/storage/emulated/0/Download/KH.py", line 302, in name
return next(self._contentSoup.find('h2').stripped_strings)
^^^^^^^^^^^^^^^^^
File "/storage/emulated/0/Download/KH.py", line 160, in lazyVersion
setattr(self, attrName, func(self))
^^^^^^^^^^
File "/storage/emulated/0/Download/KH.py", line 294, in _contentSoup
if contentSoup.find('p').string == "No such album":
^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'find'
.../0/download $

[justpanchi]

Since this script has no license (thus falling under “All Rights Reserved”), I cannot provide a modified version of the script. However, the issue stems from the default user agent used by the requests library.

Follow these steps for a quick fix:

Line 127 — add:

HEADERS = {
    'User-Agent': 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/144.0.7506.5 Safari/537.36'
}

Line 166 (now 170) — replace:

    r = requests.get(*args, **kwargs)
    return toSoup(r)

Replace with:

    if 'headers' not in kwargs:
        kwargs['headers'] = HEADERS
    r = requests.get(*args, **kwargs)
    return toSoup(r)

Line 395 (now 401) — replace:

        r = requests.get(self.url, timeout=10)

Replace with:

        r = requests.get(self.url, timeout=10, headers=HEADERS)

Line 443 (now 449) — replace:

        response = requests.get(self.url, timeout=10)

Replace with:

        response = requests.get(self.url, timeout=10, headers=HEADERS)

Line 469 (now 475) — replace:

    r = requests.get(urljoin(BASE_URL, 'search'), params={'search': term})

Replace with:

    r = requests.get(urljoin(BASE_URL, 'search'), params={'search': term}, headers=HEADERS)

[Ariancarlos]

Well that worked like a charm, thanks!

[Verymadlibrarian]

Thanks a lot for the fix !

[Bavuett]

I love you. Thanks for figuring it out for us. Hopefully the original devs merge it.

[lightmare2000]

What? Are the fuckin github soundtrack police gonna come after you? I'll upload the file in 100 different places just to prove a point on that. Stealing work is one thing, improving it is another.

[justpanchi]

What? Are the fuckin github soundtrack police gonna come after you? I'll upload the file in 100 different places just to prove a point on that. Stealing work is one thing, improving it is another.

First of all, this has nothing to do with “soundtracks,” because the topic here is licensing. And no, it’s not “another thing.” No license means “All Rights Reserved,” which gives you no rights to reuse, modify, or redistribute anything from this repository, regardless of your intentions.

On top of that, the script is filled with outdated legacy code. Starting from scratch would make far more sense than trying to maintain it.

[FluffyKn1ght]

What? Are the fuckin github soundtrack police gonna come after you? I'll upload the file in 100 different places just to prove a point on that. Stealing work is one thing, improving it is another.

🤓

[Maverynthia]

@justpanchi It's on GitHub, therefore it has an open source license. That's why you can fork it.

[justpanchi]

@justpanchi It's on GitHub, therefore it has an open source license. That's why you can fork it.

GitHub allowing forks is a technical feature, not a grant of usage rights. If a repository has no explicit license, it does not default to a permissive or open-source license. From a legal standpoint, no license means “All Rights Reserved.” You have no rights to reuse, modify, or redistribute any content of this repository.