Skip to content

Commit 151097d

Browse files
suogesiRytoEX
authored andcommitted
frontend: Fix a dereference of nullptr
`outputResolution` may not be editable and outputResolution->lineEdit() can return `nullptr` which causes crash.
1 parent 686ee75 commit 151097d

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

frontend/settings/OBSBasicSettings.cpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1610,7 +1610,10 @@ void OBSBasicSettings::LoadResolutionLists()
16101610
RecalcOutputResPixels(outputResString.c_str());
16111611
ResetDownscales(cx, cy);
16121612

1613-
ui->outputResolution->lineEdit()->setText(outputResString.c_str());
1613+
// No guarantee that outputResolution is editable, e.g., Facebook Live.
1614+
if (ui->outputResolution->isEditable()) {
1615+
ui->outputResolution->lineEdit()->setText(outputResString.c_str());
1616+
}
16141617

16151618
std::tuple<int, int> aspect = aspect_ratio(cx, cy);
16161619

0 commit comments

Comments
 (0)