Skip to content

Commit 747f67e

Browse files
tytan652PatTheMav
authored andcommitted
frontend: Do not enable crash log upload without log file
Co-authored-by: PatTheMav <PatTheMav@users.noreply.github.com>
1 parent 527e2f2 commit 747f67e

2 files changed

Lines changed: 9 additions & 1 deletion

File tree

frontend/utility/CrashHandler.cpp

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,10 @@ bool CrashHandler::hasNewCrashLog()
141141
{
142142
CrashLogUpdateResult result = updateLocalCrashLogState();
143143

144+
if (result == CrashLogUpdateResult::NotAvailable) {
145+
return false;
146+
}
147+
144148
bool hasNewCrashLog = (result == CrashLogUpdateResult::Updated);
145149
bool hasNoLogUrl = lastCrashLogURL_.empty();
146150

@@ -153,6 +157,10 @@ CrashLogUpdateResult CrashHandler::updateLocalCrashLogState()
153157

154158
std::filesystem::path lastLocalCrashLogFile = findLastCrashLog();
155159

160+
if (lastLocalCrashLogFile.empty() && lastCrashLogFile_.empty()) {
161+
return CrashLogUpdateResult::NotAvailable;
162+
}
163+
156164
if (lastLocalCrashLogFile != lastCrashLogFile_) {
157165
lastCrashLogFile_ = std::move(lastLocalCrashLogFile);
158166
lastCrashLogFileName_ = lastCrashLogFile_.filename().u8string();

frontend/utility/CrashHandler.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ class CrashHandler : public QObject {
6767
std::filesystem::path getCrashLogDirectory() const;
6868
void uploadLastCrashLog();
6969

70-
enum class CrashLogUpdateResult { InvalidResult, NotUpdated, Updated };
70+
enum class CrashLogUpdateResult { InvalidResult, NotAvailable, NotUpdated, Updated };
7171

7272
private:
7373
void checkCrashState();

0 commit comments

Comments
 (0)