Read the full file without line translation

It seems like the length reported by the channel and the one that
`really_read` expects do not match when some line ending translation is
happening. Thus try to avoid the translation.

Author: Leonidas-from-XIV

CHANGES.md

@@ -11,6 +11,8 @@
 - Fixed handling of escape sequences in JSON5. Known escapes like \b will be
   properly unescaped and undefined escape sequences will unescape to the
   character itself as per spec (#187, @david-maison-TrustInSoft)
+- Fixed tests failing on Windows due to disagreements with the length of an
+  input channel and the text mode conversion (#192, @Leonidas-from-XIV)
 
 ### Removed
 

test/test_write.ml

@@ -16,16 +16,21 @@ let to_string_tests =
       fun () -> test ~suf:"" Fixtures.json_string );
   ]
 
+let replace_crlf s =
+  (* a bit hacky as it will just remove \r even when not \r\n *)
+  let parts = String.split_on_char '\r' s in
+  String.concat "" parts
+
 let to_file_tests =
   let test ?suf expected =
     let output_file = Filename.temp_file "test_yojson_to_file" ".json" in
     Yojson.Safe.to_file ?suf output_file Fixtures.json_value;
     let file_content =
-      let ic = open_in output_file in
+      let ic = open_in_bin output_file in
       let length = in_channel_length ic in
       let s = really_input_string ic length in
       close_in ic;
-      s
+      replace_crlf s
     in
     Sys.remove output_file;
     Alcotest.(check string) __LOC__ expected file_content