Bug: ocamlformat-mlx --version 8a48bab

[davesnx]

Describe the bug

ocamlformat-mlx --version
8a48bab

ocamlformat-mlx returns version as commit hash, instead of the ocamlformat's one, causing issues like:

ocamlformat-mlx: Error while parsing /home/me/query-json/.ocamlformat:
                 Project should be formatted using ocamlformat version
                 "0.28.1", but the installed version is "8a48bab"

How to Reproduce

Install ocamlformat-mlx, have a .ocamlformat with version = 0.28.1

[andreypopp]

I guess this is because we don't release from tags?

[davesnx]

No, it's because the dune-project's version. If I set (version 0.28.1) which is the expected in .ocamlformat file, it generates the .opam files and will fail the publication, since the package has 0.28.1.1 and the generated opam 0.28.1.

I wonder if we should move to 0.28.1 version entirely, or maybe change our fork to not check the version strictly?

WDYT @andreypopp?

[davesnx]

or even disable the version check? (There's a setting for this https://github.com/ocaml-mlx/ocamlformat-mlx/blob/main/lib/Conf.ml#L272)

[andreypopp]

maybe we can fix version check to treat 0.28.1.x as 0.28.1?

[davesnx]

Yes, #11

[davesnx]

Fixed in https://github.com/ocaml-mlx/ocamlformat-mlx/releases/tag/0.28.1.2