Skip to content

Make the ppxlib driver provide a consistent set of flags #567

@mbarbin

Description

@mbarbin

This issue is extracted from a discussion that happened in this dune issue: ocaml/dune#10601

Quoting parts of this as it relates to ppxlib:

When trying to add a ppx driver flag systematically to all dune files in a repo, I ran into an issue where some instances of ppx drivers do not accept the same set of flags as in other directories. I am guessing this depends on which ppx are enabled in the (preprocess (pps ...)) stanza.

I created two PRs where I make use of the new flag unused-type-warnings (from a ppxlib preview package), one where it works, and one that exhibits the issue I am talking about, if you want to have a look.

@NathanReb made a conjecture that perhaps it would be possible to unify the set of flags provided by the driver:

Circling back to that, would fixing ppxlib's driver to provide a consistent set of flags, regardless of what ppx-es are being linked help toward having a simple variable to store ppx driver flags so one can set flags project wide?

I'm creating this issue to track further discussion on this topic as it relates to changes to ppxlib itself.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions