Skip to content

Commit bbb21e3

Browse files
committed
Fix CHANGES
* Wrap paragraphs with par * Remove experimental change log entries that aren't relevant to users * Add PR references to all fixes
1 parent f749ed6 commit bbb21e3

File tree

1 file changed

+28
-28
lines changed

1 file changed

+28
-28
lines changed

CHANGES.md

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -2,33 +2,35 @@
22

33
## Features
44

5-
- Add a new code action `Add missing rec keyword`, which is available when adding
6-
a `rec` keyword can fix `Unbound value ...` error, e.g.,
5+
- Add a new code action `Add missing rec keyword`, which is available when
6+
adding a `rec` keyword can fix `Unbound value ...` error, e.g.,
77

88
```ocaml
99
let fact n = if n = 0 then 1 else n * fact (n - 1)
1010
(* ^^^^ Unbound value fact *)
1111
```
1212

13-
Adding `rec` to the definition of `fact` will fix the problem. The new code action
14-
offers adding `rec`.
13+
Adding `rec` to the definition of `fact` will fix the problem. The new code
14+
action offers adding `rec`.
1515

16-
- Jump to the first hole on calling `Destruct` code action (only with client VSCode OCaml
17-
Platform) (#468)
16+
- Jump to the first hole on calling `Destruct` code action (only with client
17+
VSCode OCaml Platform) (#468)
1818

19-
Example: when a user invokes `Destruct` code action on `Some 1`, this code is replaced
20-
by `match Some 1 with None -> _ | Some _ -> _`, where the 1st and 3rd underscores
21-
are "typed holes", a concept created by Merlin to be able to put "holes" in OCaml code.
19+
Example: when a user invokes `Destruct` code action on `Some 1`, this code is
20+
replaced by `match Some 1 with None -> _ | Some _ -> _`, where the 1st and
21+
3rd underscores are "typed holes", a concept created by Merlin to be able to
22+
put "holes" in OCaml code.
2223

23-
With this change, now for VSCode OCaml Platform users, on such invocation of `Destruct`,
24-
the cursor will jump to the first typed hole and select it, so that user can start
25-
editing right away.
24+
With this change, now for VSCode OCaml Platform users, on such invocation of
25+
`Destruct`, the cursor will jump to the first typed hole and select it, so
26+
that user can start editing right away.
2627

2728
- Use ocamlformat to properly format type snippets. This feature requires the
2829
`ocamlformat-rpc` opam package to be installed. (#386)
2930

30-
- Add completion support for polymorphic variants, when it is possible to pin down the
31-
precise type. Examples (`<|>` stands for the cursor) when completion will work (#473)
31+
- Add completion support for polymorphic variants, when it is possible to pin
32+
down the precise type. Examples (`<|>` stands for the cursor) when completion
33+
will work (#473)
3234

3335
Function application:
3436

@@ -44,20 +46,22 @@
4446
let a : [`Alpha | `Beta] = `B<|>
4547
```
4648

47-
Note: this is actually a bug fix, since we were ignoring the backtick when constructing
48-
the prefix for completion.
49+
Note: this is actually a bug fix, since we were ignoring the backtick when
50+
constructing the prefix for completion.
4951

5052
- Parse merlin errors (best effort) into a more structured form. This allows
5153
reporting all locations as "related information" (#475)
5254

53-
- Add support for Merlin `Construct` command as completion suggestions, i.e., show complex
54-
expressions that could complete the typed hole. (#472)
55+
- Add support for Merlin `Construct` command as completion suggestions, i.e.,
56+
show complex expressions that could complete the typed hole. (#472)
5557

56-
- Add a code action `Construct an expression` that is shown when the cursor is at the end
57-
of the typed hole, i.e., `_|`, where `|` is the cursor. The code action simply triggers
58-
the client (currently only VS Code is supported) to show completion suggestions. (#472)
58+
- Add a code action `Construct an expression` that is shown when the cursor is
59+
at the end of the typed hole, i.e., `_|`, where `|` is the cursor. The code
60+
action simply triggers the client (currently only VS Code is supported) to
61+
show completion suggestions. (#472)
5962

60-
- Change the formatting-on-save error notification to a warning notification (#472)
63+
- Change the formatting-on-save error notification to a warning notification
64+
(#472)
6165

6266
- Code action to qualify ("put module name in identifiers") and unqualify
6367
("remove module name from identifiers") module names in identifiers (#399)
@@ -90,10 +94,6 @@
9094
let f x = x.Unix.tms_stime, x.Unix.tms_utime
9195
```
9296

93-
- Add support for a custom request `ocamllsp/wrappingAstNode`, which brings the smallest
94-
AST (Abstract Syntax Tree) node enclosing given position. This request is used by VS
95-
Code OCaml Platform and is not directly used by OCaml LSP users (#482)
96-
9797
## Fixes
9898

9999
- Do not show "random" documentation on hover
@@ -105,8 +105,8 @@
105105

106106
- Correctly rename a variable used as a named/optional argument (#478)
107107

108-
- When reporting an error at the beginning of the file, use the first line
109-
not the second
108+
- When reporting an error at the beginning of the file, use the first line not
109+
the second (#489)
110110

111111
# 1.7.0 (07/28/2021)
112112

0 commit comments

Comments
 (0)