Skip to content

Commit 4bf3362

Browse files
authored
feat: add **kwargs support to create_table_with_index_params for heap organization
- Add **kwargs parameter to create_table_with_index_params method - Pass **kwargs to ObTable constructor to support mysql_organization='heap' and other parameters - Set extend_existing=True as default in kwargs to maintain backward compatibility Co-authored-by: xxsc0529 <xxsc0529@users.noreply.github.com>
1 parent 9cbdb9b commit 4bf3362

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

pyobvector/client/ob_vec_client.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ def create_table_with_index_params(
6565
vidxs: Optional[IndexParams] = None,
6666
fts_idxs: Optional[list[FtsIndexParam]] = None,
6767
partitions: Optional[ObPartition] = None,
68+
**kwargs,
6869
):
6970
"""Create table with optional index_params.
7071
@@ -75,8 +76,10 @@ def create_table_with_index_params(
7576
vidxs (Optional[IndexParams]): optional vector index schema
7677
fts_idxs (Optional[List[FtsIndexParam]]): optional full-text search index schema
7778
partitions (Optional[ObPartition]): optional partition strategy
79+
**kwargs: additional keyword arguments (e.g., mysql_organization='heap')
7880
"""
7981
sparse_vidxs = self._get_sparse_vector_index_params(vidxs)
82+
kwargs.setdefault("extend_existing", True)
8083
with self.engine.connect() as conn:
8184
with conn.begin():
8285
# create table with common index
@@ -86,14 +89,14 @@ def create_table_with_index_params(
8689
self.metadata_obj,
8790
*columns,
8891
*indexes,
89-
extend_existing=True,
92+
**kwargs,
9093
)
9194
else:
9295
table = ObTable(
9396
table_name,
9497
self.metadata_obj,
9598
*columns,
96-
extend_existing=True,
99+
**kwargs,
97100
)
98101
if sparse_vidxs is not None and len(sparse_vidxs) > 0:
99102
create_table_sql = str(CreateTable(table).compile(self.engine))

0 commit comments

Comments
 (0)