Skip to content

lets-encrypt-update (probably) shouldn't die when a certificate issuance fails #1265

Open
@ethanwu10

Description

@ethanwu10

Right now, if issuing a single certificate fails, lets-encrypt-update will die with an assertion failure

assert ret == 0, 'ocf-lets-encrypt returned {}'.format(ret)

We should probably log the error and keep going, so we keep updating the remaining certificates (assuming the failure was specific to a host)—also ensuring that if any errors happen, we exit nonzero.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions