Skip to content

Commit 7546f1e

Browse files
micb25ocornut
authored andcommitted
Backends: Vulkan: ImGui_ImplVulkan_AddTexture() skips updating descriptor_set if failing to allocate. (#8677)
Reduce error surface to the check_vk_result() call.
1 parent 5220c14 commit 7546f1e

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

backends/imgui_impl_vulkan.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1376,6 +1376,7 @@ VkDescriptorSet ImGui_ImplVulkan_AddTexture(VkSampler sampler, VkImageView image
13761376
}
13771377

13781378
// Update the Descriptor Set:
1379+
if (descriptor_set != VK_NULL_HANDLE)
13791380
{
13801381
VkDescriptorImageInfo desc_image[1] = {};
13811382
desc_image[0].sampler = sampler;

docs/CHANGELOG.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,8 @@ Other Changes:
107107
- hidden scrollbar in Firefox.
108108
- Vulkan: added ImGui_ImplVulkan_PipelineInfo::ExtraDynamicStates[] to allow specifying
109109
extra dynamic states to add when creating the VkPipeline. (#9211) [@DziubanMaciej]
110+
- Vulkan: ImGui_ImplVulkan_AddTexture() skips updating descriptor_set if failing
111+
to allocate one. (#8677) [@micb25]
110112
- WebGPU: fixed undefined behaviors in example code for requesting adapter
111113
and device. (#9246, #9256) [@r-lyeh]
112114
- GLFW/SDL2/SDL3+WebGPU: removed suport for Emscripten <4.0.10. (#9281) [@ypujante]

0 commit comments

Comments
 (0)