Skip to content

Commit d09852b

Browse files
committed
Misc: promote to 5.3
1 parent 6272f3c commit d09852b

File tree

12 files changed

+2394
-444
lines changed

12 files changed

+2394
-444
lines changed

.github/workflows/build.yml

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,11 @@ jobs:
6161
skip-effects: false
6262
skip-test: false
6363
skip-doc: true
64+
- os: ubuntu-latest
65+
ocaml-compiler: ocaml-variants.5.3.0+trunk
66+
skip-effects: false
67+
skip-test: false
68+
skip-doc: true
6469

6570
runs-on: ${{ matrix.os }}
6671

@@ -83,8 +88,7 @@ jobs:
8388
default: https://github.com/ocaml-opam/opam-repository-mingw.git#sunset
8489
opam: https://github.com/ocaml/opam-repository.git
8590
dune-cache: true
86-
opam-depext: ${{ !matrix.skip-test }}
87-
opam-depext-flags: --with-test
91+
opam-depext: false
8892

8993
- name: Set-up OCaml ${{ matrix.ocaml-compiler }}
9094
if: runner.os != 'Windows'
@@ -93,8 +97,12 @@ jobs:
9397
ocaml-compiler: ${{ matrix.ocaml-compiler }}
9498
allow-prerelease-opam: true
9599
dune-cache: true
96-
opam-depext: ${{ !matrix.skip-test }}
97-
opam-depext-flags: --with-test
100+
opam-depext: false
101+
102+
- run: opam pin add ppxlib git+https://github.com/hhugo/ppxlib.git#trunk-support-53 --no-action
103+
if: ${{ matrix.ocaml-compiler == 'ocaml-variants.5.3.0+trunk' }}
104+
105+
- run: opam pin add ./ --no-action
98106

99107
- run: opam install . --best-effort
100108
if: ${{ matrix.skip-test }}

CHANGES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
js primitives in bytecode/native. It should help if one tries
1717
to understand the source of the call with gdb (see #677)
1818
* Runtime: re-enable marshalling of floats, disabled in jsoo 2.0
19+
* Compiler: initial support for OCaml 5.3
1920

2021
## Bug fixes
2122

compiler/lib/magic_number.ml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,12 @@ let v =
7777
| 5 :: 00 :: _ -> 32
7878
| 5 :: 01 :: _ -> 33
7979
| 5 :: 02 :: _ -> 34
80+
| 5 :: 03 :: _ -> 35
8081
| _ ->
81-
if Ocaml_version.compare current [ 4; 8 ] < 0
82+
if Ocaml_version.compare current [ 4; 08 ] < 0
8283
then failwith "OCaml version unsupported. Upgrade to OCaml 4.08 or newer."
8384
else (
84-
assert (Ocaml_version.compare current [ 5; 3 ] >= 0);
85+
assert (Ocaml_version.compare current [ 5; 04 ] >= 0);
8586
failwith "OCaml version unsupported. Upgrade js_of_ocaml.")
8687

8788
let current_exe = "Caml1999X", v

compiler/lib/parse_bytecode.ml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2412,7 +2412,6 @@ and compile infos pc state instrs =
24122412
| true -> State.pop 2 state
24132413
| false -> State.pop 3 state
24142414
in
2415-
24162415
compile
24172416
infos
24182417
(pc + 1)

compiler/tests-check-prim/main.output5

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ Missing
44
From main.bc:
55
caml_alloc_dummy_function
66
caml_continuation_use
7-
caml_drop_continuation
87
caml_dynlink_add_primitive
98
caml_dynlink_close_lib
109
caml_dynlink_get_current_libs
@@ -171,7 +170,6 @@ caml_spacetime_only_works_for_native_code
171170
caml_sys_const_naked_pointers_checked
172171

173172
From +toplevel.js:
174-
caml_get_section_table
175173
caml_static_alloc
176174
caml_static_free
177175
caml_terminfo_backup

compiler/tests-check-prim/unix-unix.output5

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ Missing
44
From unix.bc:
55
caml_alloc_dummy_function
66
caml_continuation_use
7-
caml_drop_continuation
87
caml_dynlink_add_primitive
98
caml_dynlink_close_lib
109
caml_dynlink_get_current_libs
@@ -282,7 +281,6 @@ caml_spacetime_only_works_for_native_code
282281
caml_sys_const_naked_pointers_checked
283282

284283
From +toplevel.js:
285-
caml_get_section_table
286284
caml_static_alloc
287285
caml_static_free
288286
caml_terminfo_backup

0 commit comments

Comments
 (0)