cluster/apiserver - fix checkResourceDefault for tests

Author: geokb

cluster/apiserver/apiserver/mains/template.go

@@ -169,7 +169,7 @@ func (s *Server) DeleteTemplate(ctx context.Context, req *metav1.DeleteOptions)
 		return nil, serr.K8sNotFoundOrInternalWithErr(err)
 	}
 
-	if err := s.checkResourceDefault(tmpl); err != nil {
+	if err := s.checkResourceDefault(tmpl); err == nil {
 		return nil, grpcutils.InvalidArg("You cannot delete the default Template: %s", tmpl.Metadata.Name)
 	}
 

cluster/apiserver/apiserver/mains/utils.go

@@ -86,7 +86,7 @@ func (s *Server) checkResourceDefault(rsc umetav1.ResourceObjectI) error {
 		return grpcutils.InvalidArg("Resource name is not set")
 	}
 
-	if strings.HasPrefix(rsc.GetMetadata().Name, "default.") {
+	if !strings.HasPrefix(rsc.GetMetadata().Name, "default.") {
 		return grpcutils.InvalidArg("This resource is not a default resource")
 	}
 

cluster/apiserver/apiserver/mains/workspace_test.go

@@ -430,13 +430,13 @@ func TestWorkspace(t *testing.T) {
 			Name: ws.Status.SpaceRef.Name,
 		})
 		assert.Nil(t, err)
-		assert.Nil(t, srv.checkResourceDefault(spc))
+		assert.Nil(t, srv.checkResourceDefault(spc), "%+v", err)
 
 		tmpl, err := srv.GetTemplate(usr.Ctx(), &metav1.GetOptions{
 			Name: ws.Status.TemplateRef.Name,
 		})
 		assert.Nil(t, err)
-		assert.Nil(t, srv.checkResourceDefault(tmpl))
+		assert.Nil(t, srv.checkResourceDefault(tmpl), "%+v", err)
 	})
 
 }