Merge pull request #74 from hakastein/chunk-txt

split TXT/SPF records longer than 255 characters

Author: ross

CHANGELOG.md

@@ -1,3 +1,7 @@
+## v0.0.8 - 20??-??-?? - ???
+
+- Split long TXT values using chunked_value before writing
+
 ## v0.0.7 - 2025-01-17 - Back to the base
 
 - Add support for Provider base class parameters

octodns_bind/__init__.py

@@ -320,9 +320,8 @@ def _apply(self, plan):
                 for value in values:
                     value = value.rdata_text
                     if record._type in ('SPF', 'TXT'):
-                        # TXT values need to be quoted
-                        value = value.replace('"', '\\"')
-                        value = f'"{value}"'
+                        # TXT values need to be quoted and split if longer than 255 characters
+                        value = record.chunked_value(value)
                     name = '@' if record.name == '' else record.name
                     if name == prev_name:
                         name = ''

tests/test_provider_octodns_bind.py

@@ -190,6 +190,31 @@ def test_list_zones_custon_extension(self):
             list(source.list_zones()),
         )
 
+    def test_split_long_txt_record(self):
+        long_txt = 'a' * 300
+
+        with TemporaryDirectory() as td:
+            provider = ZoneFileProvider('target', td.dirname)
+            desired = Zone('unit.tests.', [])
+
+            txt_record = Record.new(
+                desired,
+                'longtxt',
+                {'type': 'TXT', 'ttl': 42, 'value': long_txt},
+            )
+            desired.add_record(txt_record)
+
+            changes = [Create(txt_record)]
+            plan = Plan(None, desired, changes, True)
+            provider._apply(plan)
+
+            with open(join(td.dirname, 'unit.tests.')) as fh:
+                content = fh.read()
+                expected_split = f'"{"a" * 255}" "{"a" * 45}"'
+                self.assertIn(
+                    f'longtxt       42 IN TXT      {expected_split}', content
+                )
+
     @patch('octodns_bind.ZoneFileProvider._serial')
     def test_apply(self, serial_mock):
         serial_mock.side_effect = [424344, 454647, 484950]