[MAINT]: Express 5 support?

[dcaffull-fds]

Describe the need

It looks like createNodeMiddleware is not compatible with Express 5.

I am trying to upgrade my project to use Express 5.1 and am getting this:

Argument of type '(request: IncomingMessage, response: ServerResponse<IncomingMessage>, next?: Function | undefined) => Promise<boolean>' is not assignable to parameter of type 'PathParams'.

v1.use(createNodeMiddleware(octoApp.webhooks, {path: '/webhook'}));

I see a Renovate PR here: #613 - will that be worked on at some point soon?

Many thanks,
Dale

SDK Version

No response

API Version

No response

Relevant log output

Argument of type '(request: IncomingMessage, response: ServerResponse<IncomingMessage>, next?: Function | undefined) => Promise<boolean>' is not assignable to parameter of type 'PathParams'.

v1.use(createNodeMiddleware(octoApp.webhooks, {path: '/webhook'}));

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

[wolfy1339]

The types for Express v5 changed from void to void | Promise<void> which is why the error happens.
The middleware is compatible with Express v5, these are simply type issues that can be safely ignored.

You can wrap the middleware to catch the Promise<boolean> return type.

const middleware = createNodeMiddleware(octoApp.webhooks, {path: '/webhook'}));
v1.use(async (req, res, next) => { await middleware(req, res, next) });