Describe the need
There is a discrepancy between the getWebFlowAuthorizationUrl options and the params accepted by the login middleware: The login option is not available as a param to the login middleware.
If using the login option is desired then users must use the getWebFlowAuthorizationUrl method instead of the middleware. Is this intentional?
Is login still a valid option to the method or is the documentation outdated?
|
const { url } = app.getWebFlowAuthorizationUrl({ |
|
state: query.state, |
|
scopes: query.scopes ? query.scopes.split(",") : undefined, |
|
allowSignup: query.allowSignup |
|
? query.allowSignup === "true" |
|
: undefined, |
|
redirectUrl: query.redirectUrl, |
|
}); |
SDK Version
@octokit/oauth-app@4.2.0
API Version
No response
Relevant log output
No response
Code of Conduct
Describe the need
There is a discrepancy between the getWebFlowAuthorizationUrl options and the params accepted by the login middleware: The
loginoption is not available as a param to the login middleware.If using the
loginoption is desired then users must use thegetWebFlowAuthorizationUrlmethod instead of the middleware. Is this intentional?Is
loginstill a valid option to the method or is the documentation outdated?oauth-app.js/src/middleware/handle-request.ts
Lines 76 to 83 in 7fa986f
SDK Version
@octokit/oauth-app@4.2.0
API Version
No response
Relevant log output
No response
Code of Conduct