Skip to content

[FEAT]: Allow query.login for GET /api/github/oauth/login #397

@picchietti

Description

@picchietti

Describe the need

There is a discrepancy between the getWebFlowAuthorizationUrl options and the params accepted by the login middleware: The login option is not available as a param to the login middleware.

If using the login option is desired then users must use the getWebFlowAuthorizationUrl method instead of the middleware. Is this intentional?

Is login still a valid option to the method or is the documentation outdated?

const { url } = app.getWebFlowAuthorizationUrl({
state: query.state,
scopes: query.scopes ? query.scopes.split(",") : undefined,
allowSignup: query.allowSignup
? query.allowSignup === "true"
: undefined,
redirectUrl: query.redirectUrl,
});

SDK Version

@octokit/oauth-app@4.2.0

API Version

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    Status: Needs infoFull requirements are not yet known, so implementation should not be startedType: FeatureNew feature or request

    Type

    No type

    Projects

    Status

    🔥 Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions