Skip to content

Commit 6c43183

Browse files
arxange1BrianCArnold
arxange1
and
BrianCArnold
authored
fix: comment id model update to long instead of int
* #2927: comment id model update to long instead of int * #2927: code review fixes (1) * #2927: code review fixes (2) * #2927: comment id model update to long instead of int: unit tests fix * #2927: code review fixes * Fixed most names of parameters --------- Co-authored-by: Victor Vorobyev <[email protected]> Co-authored-by: Brian C. Arnold <[email protected]>
1 parent f5ee959 commit 6c43183

File tree

59 files changed

+942
-942
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

59 files changed

+942
-942
lines changed

‎Octokit.Reactive/Clients/IObservableCommitCommentReactionsClient.cs

+14-14
Original file line numberDiff line numberDiff line change
@@ -17,60 +17,60 @@ public interface IObservableCommitCommentReactionsClient
1717
/// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-a-commit-comment</remarks>
1818
/// <param name="owner">The owner of the repository</param>
1919
/// <param name="name">The name of the repository</param>
20-
/// <param name="number">The comment id</param>
20+
/// <param name="commentId">The comment id</param>
2121
/// <param name="reaction">The reaction to create </param>
2222
/// <returns></returns>
23-
IObservable<Reaction> Create(string owner, string name, int number, NewReaction reaction);
23+
IObservable<Reaction> Create(string owner, string name, long commentId, NewReaction reaction);
2424

2525
/// <summary>
2626
/// Creates a reaction for a specified Commit Comment
2727
/// </summary>
2828
/// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-a-commit-comment</remarks>
2929
/// <param name="repositoryId">The Id of the repository</param>
30-
/// <param name="number">The comment id</param>
30+
/// <param name="commentId">The comment id</param>
3131
/// <param name="reaction">The reaction to create </param>
3232
/// <returns></returns>
33-
IObservable<Reaction> Create(long repositoryId, int number, NewReaction reaction);
33+
IObservable<Reaction> Create(long repositoryId, long commentId, NewReaction reaction);
3434

3535
/// <summary>
3636
/// List reactions for a specified Commit Comment
3737
/// </summary>
3838
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-a-commit-comment</remarks>
3939
/// <param name="owner">The owner of the repository</param>
4040
/// <param name="name">The name of the repository</param>
41-
/// <param name="number">The comment id</param>
41+
/// <param name="commentId">The comment id</param>
4242
/// <returns></returns>
43-
IObservable<Reaction> GetAll(string owner, string name, int number);
43+
IObservable<Reaction> GetAll(string owner, string name, long commentId);
4444

4545
/// <summary>
4646
/// List reactions for a specified Commit Comment
4747
/// </summary>
4848
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-a-commit-comment</remarks>
4949
/// <param name="owner">The owner of the repository</param>
5050
/// <param name="name">The name of the repository</param>
51-
/// <param name="number">The comment id</param>
51+
/// <param name="commentId">The comment id</param>
5252
/// <param name="options">Options for changing the API response</param>
5353
/// <returns></returns>
54-
IObservable<Reaction> GetAll(string owner, string name, int number, ApiOptions options);
54+
IObservable<Reaction> GetAll(string owner, string name, long commentId, ApiOptions options);
5555

5656
/// <summary>
5757
/// List reactions for a specified Commit Comment
5858
/// </summary>
5959
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-a-commit-comment</remarks>
6060
/// <param name="repositoryId">The owner of the repository</param>
61-
/// <param name="number">The comment id</param>
61+
/// <param name="commentId">The comment id</param>
6262
/// <returns></returns>
63-
IObservable<Reaction> GetAll(long repositoryId, int number);
63+
IObservable<Reaction> GetAll(long repositoryId, long commentId);
6464

6565
/// <summary>
6666
/// List reactions for a specified Commit Comment
6767
/// </summary>
6868
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-a-commit-comment</remarks>
6969
/// <param name="repositoryId">The owner of the repository</param>
70-
/// <param name="number">The comment id</param>
70+
/// <param name="commentId">The comment id</param>
7171
/// <param name="options">Options for changing the API response</param>
7272
/// <returns></returns>
73-
IObservable<Reaction> GetAll(long repositoryId, int number, ApiOptions options);
73+
IObservable<Reaction> GetAll(long repositoryId, long commentId, ApiOptions options);
7474

7575
/// <summary>
7676
/// Deletes a reaction for a specified Commit Comment
@@ -81,7 +81,7 @@ public interface IObservableCommitCommentReactionsClient
8181
/// <param name="commentId">The comment id</param>
8282
/// <param name="reactionId">The reaction id</param>
8383
/// <returns></returns>
84-
IObservable<Unit> Delete(string owner, string name, int commentId, int reactionId);
84+
IObservable<Unit> Delete(string owner, string name, long commentId, long reactionId);
8585

8686
/// <summary>
8787
/// Deletes a reaction for a specified Commit Comment
@@ -91,6 +91,6 @@ public interface IObservableCommitCommentReactionsClient
9191
/// <param name="commentId">The comment id</param>
9292
/// <param name="reactionId">The reaction id</param>
9393
/// <returns></returns>
94-
IObservable<Unit> Delete(long repositoryId, int commentId, int reactionId);
94+
IObservable<Unit> Delete(long repositoryId, long commentId, long reactionId);
9595
}
9696
}

‎Octokit.Reactive/Clients/IObservableGistCommentsClient.cs

+3-3
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public interface IObservableGistCommentsClient
1515
/// <returns>IObservable{GistComment}.</returns>
1616
[SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get",
1717
Justification = "Method makes a network request")]
18-
IObservable<GistComment> Get(string gistId, int commentId);
18+
IObservable<GistComment> Get(string gistId, long commentId);
1919

2020
/// <summary>
2121
/// Gets all comments for the gist with the specified id.
@@ -51,7 +51,7 @@ public interface IObservableGistCommentsClient
5151
/// <param name="commentId">The id of the comment</param>
5252
/// <param name="comment">The updated body of the comment</param>
5353
/// <returns>IObservable{GistComment}.</returns>
54-
IObservable<GistComment> Update(string gistId, int commentId, string comment);
54+
IObservable<GistComment> Update(string gistId, long commentId, string comment);
5555

5656
/// <summary>
5757
/// Deletes the comment with the specified gist- and comment id.
@@ -60,6 +60,6 @@ public interface IObservableGistCommentsClient
6060
/// <param name="gistId">The id of the gist</param>
6161
/// <param name="commentId">The id of the comment</param>
6262
/// <returns>IObservable{Unit}.</returns>
63-
IObservable<Unit> Delete(string gistId, int commentId);
63+
IObservable<Unit> Delete(string gistId, long commentId);
6464
}
6565
}

‎Octokit.Reactive/Clients/IObservableIssueCommentReactionsClient.cs

+14-14
Original file line numberDiff line numberDiff line change
@@ -17,54 +17,54 @@ public interface IObservableIssueCommentReactionsClient
1717
/// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-an-issue-comment</remarks>
1818
/// <param name="owner">The owner of the repository</param>
1919
/// <param name="name">The name of the repository</param>
20-
/// <param name="number">The comment id</param>
20+
/// <param name="commentId">The comment id</param>
2121
/// <param name="reaction">The reaction to create </param>
22-
IObservable<Reaction> Create(string owner, string name, int number, NewReaction reaction);
22+
IObservable<Reaction> Create(string owner, string name, long commentId, NewReaction reaction);
2323

2424
/// <summary>
2525
/// Creates a reaction for a specified Issue Comment
2626
/// </summary>
2727
/// <remarks>https://developer.github.com/v3/reactions/#create-reaction-for-an-issue-comment</remarks>
2828
/// <param name="repositoryId">The Id of the repository</param>
29-
/// <param name="number">The comment id</param>
29+
/// <param name="commentId">The comment id</param>
3030
/// <param name="reaction">The reaction to create </param>
31-
IObservable<Reaction> Create(long repositoryId, int number, NewReaction reaction);
31+
IObservable<Reaction> Create(long repositoryId, long commentId, NewReaction reaction);
3232

3333
/// <summary>
3434
/// List reactions for a specified Issue Comment
3535
/// </summary>
3636
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue-comment</remarks>
3737
/// <param name="owner">The owner of the repository</param>
3838
/// <param name="name">The name of the repository</param>
39-
/// <param name="number">The comment id</param>
40-
IObservable<Reaction> GetAll(string owner, string name, int number);
39+
/// <param name="commentId">The comment id</param>
40+
IObservable<Reaction> GetAll(string owner, string name, long commentId);
4141

4242
/// <summary>
4343
/// List reactions for a specified Issue Comment
4444
/// </summary>
4545
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue-comment</remarks>
4646
/// <param name="owner">The owner of the repository</param>
4747
/// <param name="name">The name of the repository</param>
48-
/// <param name="number">The comment id</param>
48+
/// <param name="commentId">The comment id</param>
4949
/// <param name="options">Options for changing the API response</param>
50-
IObservable<Reaction> GetAll(string owner, string name, int number, ApiOptions options);
50+
IObservable<Reaction> GetAll(string owner, string name, long commentId, ApiOptions options);
5151

5252
/// <summary>
5353
/// List reactions for a specified Issue Comment
5454
/// </summary>
5555
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue-comment</remarks>
5656
/// <param name="repositoryId">The Id of the repository</param>
57-
/// <param name="number">The comment id</param>
58-
IObservable<Reaction> GetAll(long repositoryId, int number);
57+
/// <param name="commentId">The comment id</param>
58+
IObservable<Reaction> GetAll(long repositoryId, long commentId);
5959

6060
/// <summary>
6161
/// List reactions for a specified Issue Comment
6262
/// </summary>
6363
/// <remarks>https://developer.github.com/v3/reactions/#list-reactions-for-an-issue-comment</remarks>
6464
/// <param name="repositoryId">The Id of the repository</param>
65-
/// <param name="number">The comment id</param>
65+
/// <param name="commentId">The comment id</param>
6666
/// <param name="options">Options for changing the API response</param>
67-
IObservable<Reaction> GetAll(long repositoryId, int number, ApiOptions options);
67+
IObservable<Reaction> GetAll(long repositoryId, long commentId, ApiOptions options);
6868

6969
/// <summary>
7070
/// Deletes a reaction for a specified Issue Comment
@@ -75,7 +75,7 @@ public interface IObservableIssueCommentReactionsClient
7575
/// <param name="commentId">The comment id</param>
7676
/// <param name="reactionId">The reaction id</param>
7777
/// <returns></returns>
78-
IObservable<Unit> Delete(string owner, string name, int commentId, int reactionId);
78+
IObservable<Unit> Delete(string owner, string name, long commentId, long reactionId);
7979

8080
/// <summary>
8181
/// Deletes a reaction for a specified Commit Comment
@@ -85,6 +85,6 @@ public interface IObservableIssueCommentReactionsClient
8585
/// <param name="commentId">The comment id</param>
8686
/// <param name="reactionId">The reaction id</param>
8787
/// <returns></returns>
88-
IObservable<Unit> Delete(long repositoryId, int commentId, int reactionId);
88+
IObservable<Unit> Delete(long repositoryId, long commentId, long reactionId);
8989
}
9090
}

‎Octokit.Reactive/Clients/IObservableIssueCommentsClient.cs

+12-12
Original file line numberDiff line numberDiff line change
@@ -18,20 +18,20 @@ public interface IObservableIssueCommentsClient
1818
/// <remarks>http://developer.github.com/v3/issues/comments/#get-a-single-comment</remarks>
1919
/// <param name="owner">The owner of the repository</param>
2020
/// <param name="name">The name of the repository</param>
21-
/// <param name="id">The issue comment id</param>
21+
/// <param name="commentId">The issue comment id</param>
2222
[SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get",
2323
Justification = "Method makes a network request")]
24-
IObservable<IssueComment> Get(string owner, string name, int id);
24+
IObservable<IssueComment> Get(string owner, string name, long commentId);
2525

2626
/// <summary>
2727
/// Gets a single Issue Comment by id.
2828
/// </summary>
2929
/// <remarks>http://developer.github.com/v3/issues/comments/#get-a-single-comment</remarks>
3030
/// <param name="repositoryId">The Id of the repository</param>
31-
/// <param name="id">The issue comment id</param>
31+
/// <param name="commentId">The issue comment id</param>
3232
[SuppressMessage("Microsoft.Naming", "CA1716:IdentifiersShouldNotMatchKeywords", MessageId = "Get",
3333
Justification = "Method makes a network request")]
34-
IObservable<IssueComment> Get(long repositoryId, int id);
34+
IObservable<IssueComment> Get(long repositoryId, long commentId);
3535

3636
/// <summary>
3737
/// Gets Issue Comments for a repository.
@@ -202,34 +202,34 @@ public interface IObservableIssueCommentsClient
202202
/// <remarks>http://developer.github.com/v3/issues/comments/#edit-a-comment</remarks>
203203
/// <param name="owner">The owner of the repository</param>
204204
/// <param name="name">The name of the repository</param>
205-
/// <param name="id">The comment id</param>
205+
/// <param name="commentId">The comment id</param>
206206
/// <param name="commentUpdate">The modified comment</param>
207-
IObservable<IssueComment> Update(string owner, string name, int id, string commentUpdate);
207+
IObservable<IssueComment> Update(string owner, string name, long commentId, string commentUpdate);
208208

209209
/// <summary>
210210
/// Updates a specified Issue Comment.
211211
/// </summary>
212212
/// <remarks>http://developer.github.com/v3/issues/comments/#edit-a-comment</remarks>
213213
/// <param name="repositoryId">The Id of the repository</param>
214-
/// <param name="id">The comment id</param>
214+
/// <param name="commentId">The comment id</param>
215215
/// <param name="commentUpdate">The modified comment</param>
216-
IObservable<IssueComment> Update(long repositoryId, int id, string commentUpdate);
216+
IObservable<IssueComment> Update(long repositoryId, long commentId, string commentUpdate);
217217

218218
/// <summary>
219219
/// Deletes the specified Issue Comment
220220
/// </summary>
221221
/// <remarks>http://developer.github.com/v3/issues/comments/#delete-a-comment</remarks>
222222
/// <param name="owner">The owner of the repository</param>
223223
/// <param name="name">The name of the repository</param>
224-
/// <param name="id">The comment id</param>
225-
IObservable<Unit> Delete(string owner, string name, int id);
224+
/// <param name="commentId">The comment id</param>
225+
IObservable<Unit> Delete(string owner, string name, long commentId);
226226

227227
/// <summary>
228228
/// Deletes the specified Issue Comment
229229
/// </summary>
230230
/// <remarks>http://developer.github.com/v3/issues/comments/#delete-a-comment</remarks>
231231
/// <param name="repositoryId">The Id of the repository</param>
232-
/// <param name="id">The comment id</param>
233-
IObservable<Unit> Delete(long repositoryId, int id);
232+
/// <param name="commentId">The comment id</param>
233+
IObservable<Unit> Delete(long repositoryId, long commentId);
234234
}
235235
}

‎Octokit.Reactive/Clients/IObservableIssueReactionsClient.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public interface IObservableIssueReactionsClient
7575
/// <param name="issueNumber">The issue number</param>
7676
/// <param name="reactionId">The reaction id</param>
7777
/// <returns></returns>
78-
IObservable<Unit> Delete(string owner, string name, int issueNumber, int reactionId);
78+
IObservable<Unit> Delete(string owner, string name, int issueNumber, long reactionId);
7979

8080
/// <summary>
8181
/// Deletes a reaction for a specified Issue
@@ -85,6 +85,6 @@ public interface IObservableIssueReactionsClient
8585
/// <param name="issueNumber">The issue number</param>
8686
/// <param name="reactionId">The reaction id</param>
8787
/// <returns></returns>
88-
IObservable<Unit> Delete(long repositoryId, int issueNumber, int reactionId);
88+
IObservable<Unit> Delete(long repositoryId, int issueNumber, long reactionId);
8989
}
9090
}

0 commit comments

Comments
 (0)