Skip to content

Commit d27d1f0

Browse files
authored
Change "IssueId" to long (#2890)
* Change "IssueId" to `long` * Change "Id" to `long` in ctor * Change from `int` to `long` for issue id in "NewPullRequest"
1 parent 40041f2 commit d27d1f0

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

Octokit.Tests.Integration/Clients/ProjectCardsClientTests.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -453,7 +453,7 @@ private static async Task<ProjectCard> CreateArchivedCardHelper(IGitHubClient gi
453453
return result;
454454
}
455455

456-
private static async Task<ProjectCard> CreateIssueCardHelper(IGitHubClient githubClient, int issueId, int columnId)
456+
private static async Task<ProjectCard> CreateIssueCardHelper(IGitHubClient githubClient, long issueId, int columnId)
457457
{
458458
var newCard = new NewProjectCard(issueId, ProjectCardContentType.Issue);
459459
var result = await githubClient.Repository.Project.Card.Create(columnId, newCard);

Octokit.Tests.Integration/Reactive/ObservableProjectCardsClientTests.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -441,7 +441,7 @@ private static async Task<ProjectCard> CreateArchivedCardHelper(IObservableGitHu
441441
return result;
442442
}
443443

444-
private static async Task<ProjectCard> CreateIssueCardHelper(IObservableGitHubClient githubClient, int issueId, int columnId)
444+
private static async Task<ProjectCard> CreateIssueCardHelper(IObservableGitHubClient githubClient, long issueId, int columnId)
445445
{
446446
var newCard = new NewProjectCard(issueId, ProjectCardContentType.Issue);
447447
var result = await githubClient.Repository.Project.Card.Create(columnId, newCard);

Octokit/Models/Request/NewPullRequest.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public NewPullRequest(string title, string head, string baseRef)
3232
/// <param name="issueId">The number of an existing issue to convert into a pull request.</param>
3333
/// <param name="head">The branch (or git ref where your changes are implemented. In other words, the source branch/ref</param>
3434
/// <param name="baseRef">The base (or git ref) reference you want your changes pulled into. In other words, the target branch/ref</param>
35-
public NewPullRequest(int issueId, string head, string baseRef)
35+
public NewPullRequest(long issueId, string head, string baseRef)
3636
{
3737
Ensure.ArgumentNotNullOrEmptyString(head, nameof(head));
3838
Ensure.ArgumentNotNullOrEmptyString(baseRef, nameof(baseRef));
@@ -50,7 +50,7 @@ public NewPullRequest(int issueId, string head, string baseRef)
5050
/// <summary>
5151
/// The number of an existing issue to convert into a pull request (required if <see cref="Title"/> not provided).
5252
/// </summary>
53-
public int? IssueId { get; private set; }
53+
public long? IssueId { get; private set; }
5454

5555
/// <summary>
5656
/// The branch (or git ref) you want your changes pulled into (required).

Octokit/Models/Response/Issue.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public class Issue
1212
{
1313
public Issue() { }
1414

15-
public Issue(string url, string htmlUrl, string commentsUrl, string eventsUrl, int number, ItemState state, string title, string body, User closedBy, User user, IReadOnlyList<Label> labels, User assignee, IReadOnlyList<User> assignees, Milestone milestone, int comments, PullRequest pullRequest, DateTimeOffset? closedAt, DateTimeOffset createdAt, DateTimeOffset? updatedAt, int id, string nodeId, bool locked, Repository repository, ReactionSummary reactions, LockReason? activeLockReason, ItemStateReason? stateReason)
15+
public Issue(string url, string htmlUrl, string commentsUrl, string eventsUrl, int number, ItemState state, string title, string body, User closedBy, User user, IReadOnlyList<Label> labels, User assignee, IReadOnlyList<User> assignees, Milestone milestone, int comments, PullRequest pullRequest, DateTimeOffset? closedAt, DateTimeOffset createdAt, DateTimeOffset? updatedAt, long id, string nodeId, bool locked, Repository repository, ReactionSummary reactions, LockReason? activeLockReason, ItemStateReason? stateReason)
1616
{
1717
Id = id;
1818
NodeId = nodeId;
@@ -45,7 +45,7 @@ public Issue(string url, string htmlUrl, string commentsUrl, string eventsUrl, i
4545
/// <summary>
4646
/// The internal Id for this issue (not the issue number)
4747
/// </summary>
48-
public int Id { get; private set; }
48+
public long Id { get; private set; }
4949

5050
/// <summary>
5151
/// GraphQL Node Id

0 commit comments

Comments
 (0)