[BUG]: RepositoryVariablesClient.GetAll() returns only 10 variables

[akordowski]

What happened?

While loading a repositories GitHub Actions variables I noticed that the RepositoryVariablesClient.GetAll() function only returns 10 variables although the RepositoryVariablesCollection.TotalCount is much higher. The RepositorySecretsClient.GetAll() function on the other hand, returns the correct number of secrets (more then 10) and the count matches the RepositorySecretsCollection.TotalCount value.

I expected that the function returns the same amount of variables as the value of the RepositoryVariablesCollection.TotalCount property.

I tested the function with multiple repositories which have more then 10 variables. The result was always the same. The amount of variables was 10 and the RepositoryVariablesCollection.TotalCount matched the count of existing variables.

Versions

Octokit.NET 14.0.0

Code of Conduct

• I agree to follow this project's Code of Conduct

[akordowski]

Here a workaround:

public async Task<IReadOnlyList<RepositoryVariable>> GetRepositoryVariablesWorkaroundAsync(string owner, string repo)
{
    var variables = new List<RepositoryVariable>();
    var page = 1;
    const int perPage = 100; // GitHub's max per page

    while (true)
    {
        var endpoint = new Uri($"/repos/{owner}/{repo}/actions/variables?per_page={perPage}&page={page}", UriKind.Relative);
        var response = await _client.Connection
            .Get<RepositoryVariablesCollection>(endpoint, null, null)
            .ConfigureAwait(false);

        if (response.Body?.Variables == null || response.Body.Variables.Count == 0)
            break;

        variables.AddRange(response.Body.Variables);

        if (response.Body.Variables.Count < perPage)
            break; // Last page

        page++;
    }

    return variables;
}