Skip to content

[BUG]: faraday-multipart and faraday-retry not declared in gemspec #1744

@emmanuel-chime

Description

@emmanuel-chime

What happened?

Octokit relies on both faraday-multipart and faraday-retry.

I believe both faraday-multipart & faraday-retry should be added to the gemspec. These gems are required for users on Faraday v2 and won't add additional dependencies for users on Faraday v1 because v1 already includes these gems as of v1.9.0 (released over 3 years ago).

Versions

Octokit.rb v9.2.0

Relevant log output

To use retry middleware with Faraday v2.0+, install `faraday-retry` gem

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    Status: TriageThis is being looked at and prioritizedType: BugSomething isn't working as documented

    Type

    No type

    Projects

    Status

    🔥 Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions