Minor linting fixes

Author: kengru

frontend/src/components/accounts/AccountCard.tsx

@@ -95,11 +95,18 @@ export function AccountCard({ account }: AccountCardProps) {
             className="p-2 md:p-2.5 rounded-xl flex-shrink-0"
             style={{ backgroundColor: `${account.color}15` }}
           >
-            <Icon className="w-4 md:w-5 h-4 md:h-5" style={{ color: account.color }} />
+            <Icon
+              className="w-4 md:w-5 h-4 md:h-5"
+              style={{ color: account.color }}
+            />
           </div>
           <div className="min-w-0">
-            <h3 className="font-semibold text-quaternary text-sm md:text-base truncate">{account.name}</h3>
-            <p className="text-xs md:text-sm text-quaternary/60 truncate">{accountType.label}</p>
+            <h3 className="font-semibold text-quaternary text-sm md:text-base truncate">
+              {account.name}
+            </h3>
+            <p className="text-xs md:text-sm text-quaternary/60 truncate">
+              {accountType.label}
+            </p>
           </div>
         </div>
         <ChevronRight className="w-4 md:w-5 h-4 md:h-5 text-quaternary/30 group-hover:text-quaternary/60 group-hover:translate-x-1 transition-all flex-shrink-0" />

frontend/src/components/reports/DonutChart.tsx

@@ -46,15 +46,22 @@ export function DonutChart({
     const entries = data
       .map((cat) => [cat.category, cat.amount] as [string, number])
       .sort((a, b) => b[1] - a[1]);
-    let currentAngle = 0;
     const radius = 80;
     const circumference = 2 * Math.PI * radius;
 
-    return entries.map(([category, amount]) => {
+    return entries.map(([category, amount], index) => {
       const percentage = total > 0 ? (amount / total) * 100 : 0;
+
+      // Calculate current angle based on all previous segments
+      const currentAngle = entries
+        .slice(0, index)
+        .reduce((sum, [, prevAmount]) => {
+          const prevPercentage = total > 0 ? (prevAmount / total) * 100 : 0;
+          return sum + (prevPercentage / 100) * 360;
+        }, 0);
+
       const strokeDasharray = (percentage / 100) * circumference;
       const strokeDashoffset = -currentAngle * (circumference / 360);
-      currentAngle += (percentage / 100) * 360;
 
       return {
         category,

frontend/src/pages/Reports.tsx

@@ -122,7 +122,7 @@ export function Reports() {
     };
 
     fetchReport();
-  }, [period, currentDate]);
+  }, [period, currentDate, getDateParam]);
 
   // Currency formatting
   const currencyInfo = CURRENCIES.find((c) => c.code === report?.currency);

internal/handlers/reports.go

@@ -18,22 +18,14 @@ func NewReportHandler(db *sql.DB, exchangeService *services.ExchangeService) *Re
 	return &ReportHandler{db: db, exchangeService: exchangeService}
 }
 
-type CategoryReport struct {
-	Category   string   `json:"category"`
-	Amount     float64  `json:"amount"`
-	Budget     *float64 `json:"budget,omitempty"`
-	Percentage *float64 `json:"percentage,omitempty"`
-	Remaining  *float64 `json:"remaining,omitempty"`
-}
-
 type ReportResponse struct {
-	PeriodStart          string            `json:"period_start"`
-	PeriodEnd            string            `json:"period_end"`
-	Currency             string            `json:"currency"`
-	TotalIncome          float64           `json:"total_income"`
-	TotalExpenses        float64           `json:"total_expenses"`
-	ExpensesByCategory   []CategoryReport  `json:"expenses_by_category"`
-	FirstTransactionDate *string           `json:"first_transaction_date"`
+	PeriodStart          string             `json:"period_start"`
+	PeriodEnd            string             `json:"period_end"`
+	Currency             string             `json:"currency"`
+	TotalIncome          float64            `json:"total_income"`
+	TotalExpenses        float64            `json:"total_expenses"`
+	ExpensesByCategory   map[string]float64 `json:"expenses_by_category"`
+	FirstTransactionDate *string            `json:"first_transaction_date"`
 }
 
 func (h *ReportHandler) GetReport(w http.ResponseWriter, r *http.Request) {
@@ -139,7 +131,7 @@ func (h *ReportHandler) GetReport(w http.ResponseWriter, r *http.Request) {
 			Currency:           baseCurrency,
 			TotalIncome:        0,
 			TotalExpenses:      0,
-			ExpensesByCategory: []CategoryReport{},
+			ExpensesByCategory: make(map[string]float64),
 		}, http.StatusOK)
 		return
 	}
@@ -185,9 +177,10 @@ func (h *ReportHandler) GetReport(w http.ResponseWriter, r *http.Request) {
 		}
 
 		// Categorize based on transaction type
-		if txType == "deposit" {
+		switch txType {
+		case "deposit":
 			totalIncome += convertedAmount
-		} else if txType == "withdrawal" || txType == "expense" {
+		case "withdrawal", "expense":
 			totalExpenses += convertedAmount
 			expensesByCategory[category] += convertedAmount
 		}
@@ -209,53 +202,13 @@ func (h *ReportHandler) GetReport(w http.ResponseWriter, r *http.Request) {
 		firstTxDate = &dateStr
 	}
 
-	// Fetch user's budgets (only for monthly reports)
-	budgets := make(map[string]float64)
-	if period == "month" {
-		budgetRows, err := h.db.Query(`
-			SELECT category, monthly_limit
-			FROM category_budgets
-			WHERE user_id = ?
-		`, userID)
-		if err == nil {
-			defer budgetRows.Close()
-			for budgetRows.Next() {
-				var category string
-				var limit float64
-				if err := budgetRows.Scan(&category, &limit); err == nil {
-					budgets[category] = limit
-				}
-			}
-		}
-	}
-
-	// Build category reports with budget information
-	categoryReports := make([]CategoryReport, 0, len(expensesByCategory))
-	for category, amount := range expensesByCategory {
-		catReport := CategoryReport{
-			Category: category,
-			Amount:   amount,
-		}
-
-		// Add budget info if exists for this category
-		if budget, hasBudget := budgets[category]; hasBudget {
-			catReport.Budget = &budget
-			percentage := (amount / budget) * 100
-			catReport.Percentage = &percentage
-			remaining := budget - amount
-			catReport.Remaining = &remaining
-		}
-
-		categoryReports = append(categoryReports, catReport)
-	}
-
 	report := ReportResponse{
 		PeriodStart:          startDate.Format("2006-01-02"),
 		PeriodEnd:            endDate.Format("2006-01-02"),
 		Currency:             baseCurrency,
 		TotalIncome:          totalIncome,
 		TotalExpenses:        totalExpenses,
-		ExpensesByCategory:   categoryReports,
+		ExpensesByCategory:   expensesByCategory,
 		FirstTransactionDate: firstTxDate,
 	}
 

internal/handlers/transactions.go

@@ -542,7 +542,7 @@ func (h *TransactionHandler) Transfer(w http.ResponseWriter, r *http.Request) {
 }
 
 // Helper to get account type from string
-func (h *TransactionHandler) isAssetAccount(accountType models.AccountType) bool {
+func (h *TransactionHandler) IsAssetAccount(accountType models.AccountType) bool {
 	return accountType == models.AccountTypeCash ||
 		accountType == models.AccountTypeDebit ||
 		accountType == models.AccountTypeSaving ||