[REF] estate: Code refactored following last comments

Author: amry-odoo

estate/models/estate_property.py

@@ -1,6 +1,6 @@
 from datetime import date
 
-from odoo import fields, models, api
+from odoo import fields, models, api, _
 from odoo.tools import date_utils, float_utils
 from odoo.exceptions import UserError, ValidationError
 
@@ -66,7 +66,7 @@ class EstateProperty(models.Model):
         "res.users", name="Salesperson", default=lambda self: self.env.user
     )
     tag_ids = fields.Many2many("estate.property.tag", string="Tags")
-    offers_ids = fields.One2many(
+    offer_ids = fields.One2many(
         "estate.property.offer", "property_id", string="Offers"
     )
     best_price = fields.Float(
@@ -80,15 +80,11 @@ def _compute_total_area(self):
                 single_property.living_area + single_property.garden_area
             )
 
-    @api.depends("offers_ids.price")
+    @api.depends("offer_ids.price")
     def _compute_best_price(self):
         for single_property in self:
-            if single_property.offers_ids:
-                single_property.best_price = max(
-                    single_property.offers_ids.mapped("price")
-                )
-            else:
-                single_property.best_price = 0
+            single_property.best_price = max(single_property.offer_ids.mapped("price"), default=0)
+
 
     @api.onchange("garden")
     def _onchange_garden(self):
@@ -102,36 +98,28 @@ def _onchange_garden(self):
     def action_property_cancel(self):
         for single_property in self:
             if single_property.state == "sold":
-                raise UserError("Sold properties cannot be cancelled!")
+                raise UserError(_("Sold properties cannot be cancelled!"))
             single_property.state = "cancelled"
         return True
 
     def action_property_sold(self):
         for single_property in self:
             if single_property.state == "cancelled":
-                raise UserError("Cancelled properties cannot be sold!")
+                raise UserError(_("Cancelled properties cannot be sold!"))
             single_property.state = "sold"
         return True
 
     @api.constrains("selling_price", "expected_price")
     def check_selling_price_in_range(self):
         for single_property in self:
-            if not float_utils.float_is_zero(
-                single_property.selling_price, precision_rounding=0.1
-            ):
-                if single_property.selling_price < (
-                    0.9 * single_property.expected_price
-                ):
-                    raise ValidationError(
-                        "Selling price cannot be lower than 90%% of Expected price"
-                    )
+            if not float_utils.float_is_zero(single_property.selling_price, precision_rounding=0.1):
+                if single_property.selling_price < (0.9 * single_property.expected_price):
+                    raise ValidationError(_("Selling price cannot be lower than 90%% of Expected price"))
         return True
 
     @api.ondelete(at_uninstall=False)
     def _unlink_check_property_state(self):
         for single_property in self:
             if single_property.state not in ["new", "cancelled"]:
-                raise UserError(
-                    "Property cannot be deleted unless it is new or cancelled"
-                )
+                raise UserError(_("Property cannot be deleted unless it is new or cancelled"))
         return True

estate/models/estate_property_offer.py

@@ -1,6 +1,6 @@
 from datetime import date
 
-from odoo import fields, models, api
+from odoo import fields, models, api, _
 from odoo.tools import date_utils
 from odoo.exceptions import UserError
 
@@ -58,32 +58,24 @@ def _inverse_date_deadline(self):
     def action_offer_accept(self):
         for offer in self:
             offer.status = "accepted"
-            offer._action_check_offers()
-        return True
-
-    @api.depends("status")
-    def _action_check_offers(self):
-        if self.status == "accepted":
             if self.property_id.state in ("offer-accepted", "sold"):
                 self.status = False
-                raise UserError("An offer has already been accepted!")
+                raise UserError(_("An offer has already been accepted!"))
             else:
-                self.property_id.state = "offer-accepted"
-                self.property_id.selling_price = self.price
-                self.property_id.buyer_id = self.partner_id
+                self.property_id.write({"state": "offer-accepted", "selling_price": self.price, "buyer_id": self.partner_id})
         return True
 
     @api.depends("status")
     def action_offer_refuse(self):
-        for offer in self:
-            offer.status = "refused"
+        self.status = "refused"
         return True
 
     @api.model_create_multi
-    def create(self, vals):
-        for val in vals:
-            single_property = self.env["estate.property"].browse(val["property_id"])
-            if val["price"] < single_property.best_price:
-                raise UserError("An offer cannot be lower than an existing offer")
+    def create(self, vals_list):
+        for vals in vals_list:
+            single_property = self.env["estate.property"].browse(vals["property_id"])
+            price = vals.get("price")
+            if price is not None and price < single_property.best_price:
+                raise UserError(_("An offer cannot be lower than an existing offer"))
             single_property.state = "offer-received"
-        return super().create(vals)
+        return super().create(vals_list)

estate/views/estate_property_views.xml

@@ -62,7 +62,7 @@
                             </group>
                         </page>
                         <page string="Offers">
-                                <field name = "offers_ids" readonly="state in ['offer-accepted', 'sold', 'cancelled']"/> 
+                                <field name = "offer_ids" readonly="state in ['offer-accepted', 'sold', 'cancelled']"/> 
                         </page>
                         <page string="Other info">
                             <group>

estate/views/res_users_views.xml

@@ -12,4 +12,4 @@
               </xpath>
         </field>
     </record>
-</odoo>
+</odoo>