[ADD] estate: Chapter 10 - add SQL and python constraints

Add SQL constraints for price and uniqueness in property models and add Python constraints for the accepted price.

Author: joyep

estate/models/estate_property.py

@@ -1,18 +1,22 @@
+from dateutil.relativedelta import relativedelta
+
 from odoo import api, fields, models
 from odoo.exceptions import UserError
-from dateutil.relativedelta import relativedelta
 
 
 class EstateProperty(models.Model):
+    # ----------------------------------------
+    # Private attributes
+    # ----------------------------------------
     _name = "estate.property"
     _description = "Estate Property"
     _order = "sequence"
 
-    # Default fields
+    # ----------------------------------------
+    # Field declarations
+    # ----------------------------------------
     name = fields.Char("Title", required=True)
     sequence = fields.Integer("Sequence", default=10)
-
-    # Basic fields
     description = fields.Text("Description")
     postcode = fields.Char("Postcode")
     date_availability = fields.Date(
@@ -53,28 +57,37 @@ class EstateProperty(models.Model):
     )
     salesperson_id = fields.Many2one("res.users", string="Salesperson", default=lambda self: self.env.user)
     partner_id = fields.Many2one("res.partner", string="Partner", copy=False)
-
-    # Relational fields
     property_type_id = fields.Many2one("estate.property.type", string="Property Type")
     tag_ids = fields.Many2many("estate.property.tag", string="Tags")
     offer_ids = fields.One2many("estate.property.offer", "property_id", string="Offers")
+    total_area = fields.Integer("Total Area (sqm)", compute="_compute_total_area", store=True)
+    best_offer = fields.Float("Best Offer", compute="_compute_best_offer", store=True)
+
+    # ----------------------------------------
+    # SQL constraints
+    # ----------------------------------------
+    _price_positive = [
+        ("check_expected_price", "CHECK(expected_price > 0)", "The expected price must be positive."),
+        ("check_selling_price", "CHECK(selling_price >= 0)", "The selling price cannot be negative."),
+    ]
 
-    # Computed fields
+    # ----------------------------------------
+    # Compute methods
+    # ----------------------------------------
     @api.depends("living_area", "garden_area")
     def _compute_total_area(self):
         for record in self:
             record.total_area = record.living_area + record.garden_area
 
-    total_area = fields.Integer("Total Area (sqm)", compute="_compute_total_area", store=True)
-
     @api.depends("offer_ids.price")
     def _compute_best_offer(self):
         for record in self:
             prices = record.offer_ids.mapped("price")
             record.best_offer = max(prices) if prices else 0.0
 
-    best_offer = fields.Float("Best Offer", compute="_compute_best_offer", store=True)
-
+    # ----------------------------------------
+    # Onchange methods
+    # ----------------------------------------
     @api.onchange("garden")
     def _onchange_garden(self):
         if not self.garden:
@@ -86,7 +99,9 @@ def _onchange_garden(self):
             if not self.garden_orientation:
                 self.garden_orientation = "north"
 
-    # Action methods and other business logic
+    # ----------------------------------------
+    # Action methods
+    # ----------------------------------------
     def action_set_sold(self):
         for record in self:
             if record.status == "canceled":

estate/models/estate_property_offer.py

@@ -1,7 +1,7 @@
 from datetime import timedelta
 
 from odoo import api, fields, models
-from odoo.exceptions import UserWarning
+from odoo.exceptions import UserError
 
 
 class EstatePropertyOffer(models.Model):
@@ -22,6 +22,9 @@ class EstatePropertyOffer(models.Model):
     validity = fields.Integer("Validity (days)", default=7)
     date_deadline = fields.Date("Deadline", compute="_compute_date_deadline", inverse="_inverse_date_deadline")
 
+    # SQL constraints
+    _offer_price_positive = models.Constraint("CHECK(price > 0)")
+
     @api.depends("create_date", "validity")
     def _compute_date_deadline(self):
         for offer in self:
@@ -42,7 +45,7 @@ def action_accept_offer(self):
             # Check if there's already an accepted offer
             other_offers = offer.property_id.offer_ids - offer
             if any(other_offers.filtered(lambda o: o.status == "accepted")):
-                raise UserWarning("An offer has already been accepted for this property.")
+                raise UserError("An offer has already been accepted for this property.")
             offer.status = "accepted"
             # Refuse other offers for the same property
             other_offers.write({"status": "refused"})

estate/models/estate_property_tag.py

@@ -6,3 +6,5 @@ class EstatePropertyTag(models.Model):
     _description = "Estate Property Tag"
 
     name = fields.Char("Name", required=True)
+
+    _tag_name_unique = models.Constraint("UNIQUE(name)")

estate/models/estate_property_type.py

@@ -6,3 +6,5 @@ class EstatePropertyType(models.Model):
     _description = "Estate Property Type"
 
     name = fields.Char("Name", required=True)
+
+    _property_type_name_unique = models.Constraint("UNIQUE(name)")