[IMP] estate: added sql constraints and python constraints, fixed offer view

Author: danal-odoo

estate/models/estate_property.py

@@ -1,12 +1,19 @@
 #!/usr/bin/env python3
 from dateutil.relativedelta import relativedelta
+from odoo.exceptions import ValidationError
 
 from odoo import api, models, fields, exceptions
 
 
 class EstateProperty(models.Model):
     _name = "estate.property"
     _description = "Estate Property"
+    _check_expected_price = models.Constraint(
+        "CHECK(expected_price > 0)", "A property expected price must be strictly positive."
+    )
+    _check_selling_price = models.Constraint(
+        "CHECK(selling_price >= 0)", "A property selling price must be positive."
+    )
 
     name = fields.Char(required=True, default="Unknown")
     description = fields.Text()
@@ -76,6 +83,7 @@ def _onchange_garden(self):
             self.garden_orientation = "north"
         else:
             self.garden_area = 0
+            self.garden_orientation = None
 
     def action_sold_property(self):
         for record in self:
@@ -92,3 +100,16 @@ def action_cancel_offer(self):
             else:
                 record.state = "cancelled"
         return True
+
+    @api.constrains("selling_price", "expected_price")
+    def _check_selling_price_persentage(self):
+        for record in self:
+            selling_price_persentage = (
+                record.selling_price / record.expected_price
+            ) * 100
+            if selling_price_persentage >= 90 or selling_price_persentage == 0:
+                pass
+            else:
+                raise ValidationError(
+                    "The selling price cannot be lower than 90% of the expected price."
+                )

estate/models/estate_property_offer.py

@@ -6,7 +6,10 @@
 class EstatePropertyOffer(models.Model):
     _name = "estate.property.offer"
     _description = "Estate Property Offer"
-
+    _check_offer_price = models.Constraint(
+        "CHECK(price > 0)", "An offer price must be strictly positive"
+    )
+    
     price = fields.Float()
     status = fields.Selection(
         selection=[("accepted", "Accepted"), ("refused", "Refused")], copy=False

estate/models/estate_property_tag.py

@@ -4,5 +4,8 @@
 class EstatePropertyTags(models.Model):
     _name = "estate.property.tag"
     _description = "Estate Property Tag"
+    _check_tag_name = models.Constraint(
+        "UNIQUE(name)", "A property tag name should be unique."
+    )
 
     name = fields.Char(required=True)

estate/models/estate_property_type.py

@@ -5,5 +5,8 @@
 class EstatePropertyType(models.Model):
     _name = "estate.property.type"
     _description = "Estate Property Type"
+    _check_type_name = models.Constraint(
+        "UNIQUE(name)", "A property type name should be unique."
+    )
 
     name = fields.Char(required=True)

estate/views/estate_property_views.xml

@@ -118,8 +118,8 @@
                 <field name="partner_id"/>
                 <field name="validity" string="Validity(days)"/>
                 <field name="date_deadline"/>
-                <button name="action_accept" string="Accept" type="object" icon="fa-check"/>
-                <button name="action_refuse" string="Refuse" type="object" icon="fa-times"/>        
+                <button name="action_accept" string="Accept" type="object" icon="fa-check" invisible="status in ('accepted', 'refused')"/>
+                <button name="action_refuse" string="Refuse" type="object" icon="fa-times" invisible="status in ('accepted', 'refused')"/>        
                 <field name="status"/>
             </list>
         </field>