ODR violation with `ThreadContextManager::instance()` when using quill across multiple shared libraries

[wangjunbo4]

Environment

• OS: Linux (CentOS/RHEL)
• Compiler: GCC with AddressSanitizer enabled

Problem

My project structure includes:

• A main executable
• Multiple shared libraries

All components include quill headers and use the logging functionality. When running with AddressSanitizer, I get the following error:

==4093084==ERROR: AddressSanitizer: odr-violation (0x7f52feedd800):
  [1] size=32 'instance' /path/to/quill/core/ThreadContextManager.h:216:33 in lib.so
  [2] size=32 'instance' /path/to/quill/core/ThreadContextManager.h:216:33 in main

QUILL_EXPORT static ThreadContextManager& instance() noexcept
{
  static ThreadContextManager instance;  // <-- ODR violation here
  return instance;
}

Questions

• What is the recommended way to use quill in a multi-shared-library project?
• Is there a planned fix for this ODR issue in header-only mode?

[apozzer305]

Hey, thanks for reporting. I am not able to reproduce using this example
https://github.com/odygrd/quill/tree/shared_lib/examples/shared_library

Can you please try to submit a reproducible example including also the gcc version used

[odygrd]

I cannot reproduce the ODR violation using the above example on Linux.
Runtime behavior is correct - all libraries share the same ThreadContextManager.

The ASAN reports might be a false positive. Please can you let us know:

1. Do you actually see different addresses when printing &ThreadContextManager::instance() from each library?
2. What's your GCC version? (gcc --version)
3. Are you using -fvisibility=hidden?