Before opening a new PR, check if one already exists for the same thing #780
BarsatZulkarnine
started this conversation in
General
Replies: 1 comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Not a criticism of anyone - the response to this project has been incredible and the contributions are genuinely good. But looking at the open PRs right now there are some clear duplicate clusters that are making Felix's life harder than it needs to be:
Each of those is Felix having to read multiple implementations of the same fix, figure out which one is better, and deal with merge conflicts after picking one. That compounds fast at 150+ open PRs.
The most useful thing most of us can do right now is probably not open another PR. It's go review the ones already open. Leave a comment, test it locally, flag a bug, approve it if it looks good. A PR that sits unreviewed helps nobody. A reviewed PR can actually get merged.
Before opening anything new, worth spending 10 minutes searching open PRs for the same issue. If one exists, review it and leave a comment rather than opening a parallel one.
Beta Was this translation helpful? Give feedback.
All reactions