From 5c284dc44d30ac2e322198f16bbbd7a180371bd7 Mon Sep 17 00:00:00 2001 From: Juanje Mendoza Date: Tue, 10 Mar 2026 09:04:10 +0100 Subject: [PATCH 1/5] Fix error when creating check on internal PR --- .github/workflows/run-rsfc.yml | 14 +++++++++----- .github/workflows/use-rsfc.yml | 1 + README.md | 4 +++- 3 files changed, 13 insertions(+), 6 deletions(-) diff --git a/.github/workflows/run-rsfc.yml b/.github/workflows/run-rsfc.yml index a63cb68..6fe3d3e 100644 --- a/.github/workflows/run-rsfc.yml +++ b/.github/workflows/run-rsfc.yml @@ -9,6 +9,9 @@ on: is_fork: required: true type: boolean + pr_sha: + required: false + type: string secrets: RSFC_TOKEN: required: false @@ -82,15 +85,16 @@ jobs: uses: actions/github-script@v7 with: script: | - const pr = context.payload.pull_request const jobId = "${{ steps.get_job.outputs.job_id }}" - const url = `https://github.com/${context.payload.repository.owner.login}/${context.payload.repository.name}/actions/runs/${context.runId}/job/${jobId}` + const headSha = "${{ inputs.pr_sha || github.sha }}" + const owner = context.repo.owner + const repo = context.repo.repo await github.rest.checks.create({ - owner: context.payload.repository.owner.login, - repo: context.payload.repository.name, + owner: owner + repo: repo, name: "View report RSFC", - head_sha: pr.head.sha, + head_sha: headSha, status: "completed", conclusion: "neutral", output: { diff --git a/.github/workflows/use-rsfc.yml b/.github/workflows/use-rsfc.yml index 2906214..54c41d6 100644 --- a/.github/workflows/use-rsfc.yml +++ b/.github/workflows/use-rsfc.yml @@ -11,5 +11,6 @@ jobs: with: repo_url: https://github.com/${{ github.repository }} is_fork: ${{ github.event.pull_request.head.repo.full_name != github.repository }} + pr_sha: ${{ github.event.pull_request.head.sha }} secrets: RSFC_TOKEN: ${{ secrets.RSFC_TOKEN }} \ No newline at end of file diff --git a/README.md b/README.md index 0311f76..59a048d 100644 --- a/README.md +++ b/README.md @@ -268,5 +268,7 @@ jobs: uses: oeg-upm/rsfc/.github/workflows/run-rsfc.yml@main with: repo_url: https://github.com/${{ github.repository }} + is_fork: ${{ github.event.pull_request.head.repo.full_name != github.repository }} + pr_sha: ${{ github.event.pull_request.head.sha }} secrets: - RSFC_TOKEN: ${{ secrets.RSFC_TOKEN }} \ No newline at end of file + RSFC_TOKEN: ${{ secrets.RSFC_TOKEN }} \ No newline at end of file From dd29adb5448660aa45532dfb287dc26d8e5d602e Mon Sep 17 00:00:00 2001 From: juanjemdIos <116972173+juanjemdIos@users.noreply.github.com> Date: Tue, 10 Mar 2026 09:15:49 +0100 Subject: [PATCH 2/5] Fix formatting in README.md Remove extra newline before example section --- README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/README.md b/README.md index 1e830fe..dfcd0b9 100644 --- a/README.md +++ b/README.md @@ -252,7 +252,6 @@ To download it: 2. Select the job **Run RSFC Analysis** 3. Download the artifact from the **Artifacts** section - Example: ```yaml From 90b345d3fe1e28b9bef168f8c588820ab4c1db0f Mon Sep 17 00:00:00 2001 From: juanjemdIos <116972173+juanjemdIos@users.noreply.github.com> Date: Tue, 10 Mar 2026 09:33:18 +0100 Subject: [PATCH 3/5] Update workflow to use fixed branch for rsfc checks --- .github/workflows/use-rsfc.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/use-rsfc.yml b/.github/workflows/use-rsfc.yml index 54c41d6..611db3e 100644 --- a/.github/workflows/use-rsfc.yml +++ b/.github/workflows/use-rsfc.yml @@ -7,10 +7,10 @@ on: jobs: run-rsfc-checks: - uses: oeg-upm/rsfc/.github/workflows/run-rsfc.yml@main + uses: juanjemdIos/oeg_rsfc/.github/workflows/run-rsfc.yml@fix_internal_PR with: repo_url: https://github.com/${{ github.repository }} is_fork: ${{ github.event.pull_request.head.repo.full_name != github.repository }} pr_sha: ${{ github.event.pull_request.head.sha }} secrets: - RSFC_TOKEN: ${{ secrets.RSFC_TOKEN }} \ No newline at end of file + RSFC_TOKEN: ${{ secrets.RSFC_TOKEN }} From 1ee98301228d7ec62b587cc78ac1c1aacdcf342c Mon Sep 17 00:00:00 2001 From: juanjemdIos <116972173+juanjemdIos@users.noreply.github.com> Date: Tue, 10 Mar 2026 09:39:40 +0100 Subject: [PATCH 4/5] Fix syntax error in GitHub Actions workflow --- .github/workflows/run-rsfc.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/run-rsfc.yml b/.github/workflows/run-rsfc.yml index 6fe3d3e..bdfdd04 100644 --- a/.github/workflows/run-rsfc.yml +++ b/.github/workflows/run-rsfc.yml @@ -91,7 +91,7 @@ jobs: const repo = context.repo.repo await github.rest.checks.create({ - owner: owner + owner: owner, repo: repo, name: "View report RSFC", head_sha: headSha, From f225ad55f08d10e41a8f6631d74910d4bdc6b08d Mon Sep 17 00:00:00 2001 From: juanjemdIos <116972173+juanjemdIos@users.noreply.github.com> Date: Tue, 10 Mar 2026 09:45:31 +0100 Subject: [PATCH 5/5] Update workflow to use main branch for rsfc checks --- .github/workflows/use-rsfc.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/use-rsfc.yml b/.github/workflows/use-rsfc.yml index 611db3e..cbc547f 100644 --- a/.github/workflows/use-rsfc.yml +++ b/.github/workflows/use-rsfc.yml @@ -7,7 +7,7 @@ on: jobs: run-rsfc-checks: - uses: juanjemdIos/oeg_rsfc/.github/workflows/run-rsfc.yml@fix_internal_PR + uses: oeg-upm/rsfc/.github/workflows/run-rsfc.yml@main with: repo_url: https://github.com/${{ github.repository }} is_fork: ${{ github.event.pull_request.head.repo.full_name != github.repository }}