Skip to content

Commit b70b875

Browse files
authored
Merge pull request #113 from Str3am786/soca_3.10
Fixes to issues, and updating url to dashboard
2 parents 6da16d4 + f408c96 commit b70b875

File tree

9 files changed

+236
-208
lines changed

9 files changed

+236
-208
lines changed

src/soca/assets/template.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
<h2 id="nav-title">Software Catalog</h2>
1717
<input id="searchBar" placeholder="Search for repositories..." title="Type in a repository" type="text"/>
1818
<div data-toggle="tooltip" data-placement="right" title="About page"><a href="about.html"><img src="img/help.png" class="grey-color-svg" style="height: 2rem; margin-left: 1rem;"></a></div>
19-
<div data-toggle="tooltip" data-placement="right" title="SOCA Dashboard Analytics"><a href="https://dashboards-software.oeg.fi.upm.es/d/FX3TNka4k/prototype?orgId=1&from=now-6M&to=now&var-organisation=oeg-upm&var-SOCA_Version=0.0.2&var-SOMEF_Version=0.9.3&kiosk" target="_blank"><img src="img/statIcon.svg" class="grey-color-svg" style="height: 2rem; margin-left: 1rem;"></a></div>
19+
<div data-toggle="tooltip" data-placement="right" title="SOCA Dashboard Analytics"><a href="https://dashboards-software.oeg.fi.upm.es/d/FX3TNka4k/prototype?orgId=1&from=now-6M&to=now&var-organisation=oeg-upm&var-SOCA_Version=0.0.3&var-SOMEF_Version=0.9.3&kiosk" target="_blank"><img src="img/statIcon.svg" class="grey-color-svg" style="height: 2rem; margin-left: 1rem;"></a></div>
2020
</div>
2121

2222
<div class="filters-wrapper">

src/soca/commands/create_summary.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
from datetime import date, datetime
22
import json
33
import os
4-
from soca import __version__ as soca_ver
4+
from .. import __version__ as soca_ver
55
from somef import __version__ as somef_ver
66
from .upload_summary import upload_summary
77

src/soca/commands/portal/metadata.py

Lines changed: 199 additions & 197 deletions
Large diffs are not rendered by default.

src/soca/commands/portal/portal.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@
99
from . import card
1010
from . import scripts
1111
from . import metadata
12-
from soca import base_dir
13-
from soca import __version__
12+
from ... import base_dir, __version__
1413

1514

1615
def generate(repo_metadata_dir, output, title, favicon):

src/soca/commands/portal/scripts.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from soca import base_dir
1+
from ... import base_dir
22

33
def singleton(class_):
44
instances = {}

src/soca/commands/portal/styles.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from soca import base_dir
1+
from ... import base_dir
22

33
def singleton(class_):
44
instances = {}

src/soca/commands/upload_summary.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ def summaryToDatabase(summary_output):
9191
'num_doi': summary_output['identifiers']['num_pid'],
9292
'num_pid': summary_output['identifiers']['num_pid'],
9393
'num_withoutId': summary_output['identifiers']['num_without_identifier'],
94-
'num_withId': summary_output['identifiers']['num_pid'] +summary_output['identifiers']['num_pid'],
94+
'num_withId': summary_output['identifiers']['num_pid'] +summary_output['identifiers']['num_doi'],
9595
'num_Apache': summary_output['licenses']['APACHE'],
9696
'num_GPL': summary_output['licenses']['GPL'],
9797
'num_MIT': summary_output['licenses']['MIT'],

tests/json_files/issue_111_mapeathor.json

Lines changed: 1 addition & 0 deletions
Large diffs are not rendered by default.

tests/test-scc.py

Lines changed: 30 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@
55
from pathlib import Path
66
from datetime import datetime
77

8-
import soca.commands.portal.metadata as md
9-
import soca.commands.portal.portal as portal
10-
import soca.commands.create_summary as summary
8+
import src.soca.commands.portal.metadata as md
9+
import src.soca.commands.portal.portal as portal
10+
import src.soca.commands.create_summary as summary
1111
#from ..src.soca.commands.portal.metadata import metadata as m
12-
import soca.commands.extract_metadata as ex
12+
import src.soca.commands.extract_metadata as ex
1313

1414

1515
class test_soca(TestCase):
@@ -435,6 +435,9 @@ def test_r4r(self):
435435
r4r.html_repo_icons()
436436
pass
437437

438+
439+
440+
#TODO move into its own class, for summary testing
438441
def test_ontology(self):
439442
path = Path(__file__).parent / "json_files" / "ontologytest.json"
440443
with path.open() as f:
@@ -446,6 +449,29 @@ def test_ontology(self):
446449
if len(dir) == 0:
447450
os.rmdir(path2)
448451
pass
452+
453+
#Tests for issues/repos that cause problems metadata.py
454+
455+
def test_issue111(self):
456+
"""This is to test CFF extraction"""
457+
path = Path(__file__).parent / "json_files" / "issue_111_mapeathor.json"
458+
with path.open() as f:
459+
mapjayson = json.load(f)
460+
f.close()
461+
meta = md.metadata(path, mapjayson)
462+
result = meta.citations()
463+
assert(result['cff'])
464+
def test_issue111_2(self):
465+
"""Mapeathor test to see if the card is built properly"""
466+
path = Path(__file__).parent / "json_files" / "issue_111_mapeathor.json"
467+
with path.open() as f:
468+
mapjayson = json.load(f)
469+
f.close()
470+
meta = md.metadata(path, mapjayson)
471+
res = meta.html_repo_icons()
472+
result = "cff-version: 1.0.0" in res
473+
self.assertTrue(result)
474+
449475

450476

451477
if __name__ == '__main__':

0 commit comments

Comments
 (0)