Skip to content

Commit 391ded8

Browse files
committed
Keep release archive signing automatic
1 parent 97376da commit 391ded8

4 files changed

Lines changed: 6 additions & 4 deletions

File tree

.github/workflows/release.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@ jobs:
120120
121121
- name: Build release archive
122122
env:
123+
ARCHIVE_CODE_SIGN_STYLE: Automatic
123124
ARCHIVE_CODE_SIGN_IDENTITY: Apple Development
124125
ARCHIVE_PROVISIONING_PROFILE_SPECIFIER: ${{ env.ARCHIVE_PROVISIONING_PROFILE_SPECIFIER }}
125126
RELEASE_PROVISIONING_PROFILE_SPECIFIER: ${{ env.RELEASE_PROVISIONING_PROFILE_SPECIFIER }}

RELEASING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ Signed archive + zip:
7272
./scripts/release/build_release.sh
7373
```
7474

75-
`build_release.sh` now archives with automatic signing against the WeatherKit-enabled development profile installed on the machine, pins the archive profile name from `ARCHIVE_PROVISIONING_PROFILE_SPECIFIER`, then performs a `developer-id` export so the release artifact keeps the WeatherKit entitlement while still shipping as a Developer ID app.
75+
`build_release.sh` archives with automatic signing against the WeatherKit-enabled development profile installed on the machine, then performs a `developer-id` export so the release artifact keeps the WeatherKit entitlement while still shipping as a Developer ID app. For local/manual release experiments, `ARCHIVE_CODE_SIGN_STYLE=Manual` can be combined with `ARCHIVE_PROVISIONING_PROFILE_SPECIFIER`, but the GitHub workflow intentionally keeps archive signing automatic so the app and helper targets can resolve their own signing requirements.
7676

7777
The repository's `Release` configuration now uses the WeatherKit entitlement. The direct-download path therefore depends on both provisioning profile secrets listed above: the development profile for the archive phase and the direct-distribution profile for the export phase.
7878

docs/releases/v15.2.1.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ This release ships the new **Rescue** dashboard page for advanced Apple Silicon
1212
- Adds copyable `usbcfwflasher` diagnosis and recovery templates for explicit technician use
1313
- Adds NVMe SMART health parsing when `smartctl` is installed, including percentage used, data written, unsafe shutdowns, and media/data errors
1414
- Adds parser coverage for recovered UG400/RID2-style controller states and SMART output
15-
- Pins the archive provisioning profile during automated release builds so Xcode uses the intended signing profile
15+
- Tightens release signing configuration while keeping archive signing automatic for the app/helper target pair
1616

1717
## Safety Note
1818

scripts/release/build_release.sh

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ APP_PATH="${EXPORT_DIR}/Core-Monitor.app"
99
ZIP_PATH="${ZIP_PATH:-${BUILD_DIR}/Core-Monitor.app.zip}"
1010
DERIVED_DATA_PATH="${DERIVED_DATA_PATH:-${ROOT_DIR}/build/DerivedData/release}"
1111
DEVELOPMENT_TEAM="${DEVELOPMENT_TEAM:-6VDP675K4L}"
12+
ARCHIVE_CODE_SIGN_STYLE="${ARCHIVE_CODE_SIGN_STYLE:-Automatic}"
1213
ARCHIVE_CODE_SIGN_IDENTITY="${ARCHIVE_CODE_SIGN_IDENTITY:-Apple Development}"
1314
ARCHIVE_PROVISIONING_PROFILE_SPECIFIER="${ARCHIVE_PROVISIONING_PROFILE_SPECIFIER:-}"
1415
RELEASE_CODE_SIGN_IDENTITY="${RELEASE_CODE_SIGN_IDENTITY:-Developer ID Application}"
@@ -21,11 +22,11 @@ mkdir -p "${EXPORT_DIR}"
2122
mkdir -p "${DERIVED_DATA_PATH}"
2223

2324
archive_signing_args=(
24-
CODE_SIGN_STYLE=Automatic
25+
CODE_SIGN_STYLE="${ARCHIVE_CODE_SIGN_STYLE}"
2526
CODE_SIGN_IDENTITY="${ARCHIVE_CODE_SIGN_IDENTITY}"
2627
)
2728

28-
if [[ -n "${ARCHIVE_PROVISIONING_PROFILE_SPECIFIER}" ]]; then
29+
if [[ "${ARCHIVE_CODE_SIGN_STYLE}" == "Manual" && -n "${ARCHIVE_PROVISIONING_PROFILE_SPECIFIER}" ]]; then
2930
archive_signing_args+=(
3031
PROVISIONING_PROFILE_SPECIFIER="${ARCHIVE_PROVISIONING_PROFILE_SPECIFIER}"
3132
)

0 commit comments

Comments
 (0)