Skip to content

Commit 70265ac

Browse files
more pre-commit file fixes
Signed-off-by: Michael Clifford <mcliffor@redhat.com>
1 parent e05e3cf commit 70265ac

17 files changed

Lines changed: 15 additions & 29 deletions

File tree

demos/rag_agentic/src/4_OCP_version_info_email.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@
7575
"""Summarize the latest Red Hat OpenShift version number and any significant features, fixes, or changes that occure in this version.""",
7676
"""Draft and format an email to convey this information to my team members."""
7777
]
78-
for i, prompt in enumerate(prompts):
78+
for i, prompt in enumerate(prompts):
7979
turn_response = agent.create_turn(
8080
messages=[
8181
{
@@ -103,4 +103,3 @@
103103
)
104104
for log in EventLogger().log(turn_response):
105105
log.print()
106-

kubernetes/llama-stack/otel-collector-sidecar.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,4 +55,3 @@ spec:
5555
resources: {}
5656
replicas: 1
5757
ipFamilyPolicy: SingleStack
58-

kubernetes/mcp-servers/ansible-mcp/ansible-service.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,3 @@ spec:
1010
- port: 8000
1111
targetPort: http
1212
protocol: TCP
13-

kubernetes/observability/README.md

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ Metrics and traces will be distributed from the OTC to various backends. Tempo i
1818
2. **Tempo Operator**: Provides `TempoStack` Custom Resource. This is the backend for distributed tracing.
1919
An S3-compatible storage (Minio) is paired with Tempo.
2020

21-
3. **Cluster Observability Operator**: This provides PodMonitor and ServiceMonitor Custom Resources which are necessary for
22-
user-workload monitoring's prometheus to scrape workload metrics. Also, the COO provides UIPlugins for viewing telemetry.
21+
3. **Cluster Observability Operator**: This provides PodMonitor and ServiceMonitor Custom Resources which are necessary for
22+
user-workload monitoring's prometheus to scrape workload metrics. Also, the COO provides UIPlugins for viewing telemetry.
2323

2424
3. **(optional) Grafana Operator**: Provides Grafana APIs including `GrafanaDashboard`, `Grafana`, and `GrafanaDataSource` that will be used to visualize telemetry.
2525

@@ -48,7 +48,7 @@ In order to view distributed tracing data from LLamastack and/or vLLM, you must
4848
is Tempo. See the OpenShift Tempo
4949
[documentation](https://docs.redhat.com/en/documentation/openshift_container_platform/4.18/html/distributed_tracing/distributed-tracing-platform-tempo#distr-tracing-tempo-install-tempostack-web-console_dist-tracing-tempo-installing)
5050
for further details. Tempo must be paired with a storage solution. For this example, `MinIO` is used. The necessary resources can be created by
51-
applying the `./tempo` manifests.
51+
applying the `./tempo` manifests.
5252

5353
```bash
5454
# edit storageclassName & secret as necessary
@@ -113,15 +113,15 @@ oc patch deployment deployment-name \
113113

114114
The Jaeger frontend feature of TempoStack is no longer supported by Red Hat. This has been replaced by the COO UIPlugin. To create the UIPlugin for
115115
Tracing, first ensure the TempoStack described above is created. This is a prerequisite. Then, all that's necessary to view traces from
116-
the OpenShift console at `Observe -> Traces` is to create the following [Tracing UIPlugin resource](./tracing-ui-plugin.yaml).
116+
the OpenShift console at `Observe -> Traces` is to create the following [Tracing UIPlugin resource](./tracing-ui-plugin.yaml).
117117

118118
```bash
119119
oc apply ./tracing-ui-plugin.yaml
120120
```
121121

122-
You should now see traces and metrics in the OpenShift console, from the `Oberve` tab.
122+
You should now see traces and metrics in the OpenShift console, from the `Oberve` tab.
123123

124-
### Grafana
124+
### Grafana
125125

126126
Most users are familiar with Grafana for visualizing and analyzing telemetry. To create the Grafana resources necessary to view
127127
Llamastack and vLLM telemetry, follow the below example.
@@ -143,7 +143,7 @@ Upon success, you can explore metrics and traces from Grafana route.
143143
To create a `vLLM` GrafanaDashboard, run
144144

145145
```bash
146-
oc apply -n observability-hub -f vllml-dashboard/vllm-dashboard.yaml
146+
oc apply -n observability-hub -f vllml-dashboard/vllm-dashboard.yaml
147147
```
148148

149149
You should now see a dashboard named `vLLM` in the Grafana console by choosing `Dashboards` from the left navigation bar.
@@ -157,8 +157,7 @@ This [dashboard](./grafana/cluster-metrics-dashboard/cluster_metrics.ocp.json) i
157157
https://github.com/kevchu3/openshift4-grafana/blob/master/dashboards/json_raw/cluster_metrics.ocp416.json
158158

159159
```bash
160-
oc apply -n observability-hub -f cluster-metrics-dashboard/cluster-metrics.yaml
160+
oc apply -n observability-hub -f cluster-metrics-dashboard/cluster-metrics.yaml
161161
```
162162

163163
You should now see a dashboard named `cluster-metrics` in the Grafana console by choosing `Dashboards` from the left navigation bar.
164-

kubernetes/observability/grafana/cluster-metrics-dashboard/cluster-metrics.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,3 @@ spec:
1010
dashboards: grafana # This label matches the grafana Grafana instance
1111
# This json was copied and modified from https://github.com/kevchu3/openshift4-grafana/blob/master/dashboards/json_raw/cluster_metrics.ocp416.json
1212
url: https://raw.githubusercontent.com/redhat-et/edge-ocp-observability/refs/heads/main/observability-hub/grafana/cluster-metrics-dashboard/cluster_metrics_ocp.json
13-
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
apiVersion: kustomize.config.k8s.io/v1beta1
22
kind: Kustomization
3-
3+
44
namespace: observability-hub
55
resources:
66
- grafana-instance.yaml
@@ -9,4 +9,3 @@ resources:
99
- grafana-sa.yaml
1010
- route.yaml
1111
- datasources.yaml
12-

kubernetes/observability/grafana/vllm-dashboard/vllm-grafana-openshift.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1566,4 +1566,4 @@
15661566
"title": "vLLM",
15671567
"uid": "b281712d-8bff-41ef-9f3f-71ad43c05e9b7",
15681568
"version": 4
1569-
}
1569+
}

kubernetes/observability/otel-collector/clusterrole.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,4 +26,3 @@ subjects:
2626
name: otel-collector
2727
# update if not using observability-hub namespace
2828
namespace: observability-hub
29-

kubernetes/observability/otel-collector/kustomization.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
apiVersion: kustomize.config.k8s.io/v1beta1
22
kind: Kustomization
3-
3+
44
namespace: observability-hub
55
resources:
66
- sa.yaml

kubernetes/observability/otel-collector/sa.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,3 @@ apiVersion: v1
22
kind: ServiceAccount
33
metadata:
44
name: otel-collector
5-

0 commit comments

Comments
 (0)