Skip to content

Commit f676206

Browse files
fix: Add ReplicaSet cache and RBAC access for generated config cleanup (#309)
Generated config cleanup lists ReplicaSets to preserve ConfigMaps still referenced by in-flight rollouts. Add ReplicaSet cache coverage and RBAC so that lookup works reliably under the controller-runtime cached client. --------- Signed-off-by: Vaishnavi Hire <vhire@redhat.com>
1 parent 7a0f3d9 commit f676206

4 files changed

Lines changed: 26 additions & 0 deletions

File tree

config/rbac/role.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,14 @@ rules:
6363
- patch
6464
- update
6565
- watch
66+
- apiGroups:
67+
- apps
68+
resources:
69+
- replicasets
70+
verbs:
71+
- get
72+
- list
73+
- watch
6674
- apiGroups:
6775
- autoscaling
6876
resources:

controllers/kubebuilder_rbac.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ package controllers
77

88
// Deployment permissions - controller creates and manages deployments
99
//+kubebuilder:rbac:groups=apps,resources=deployments,verbs=get;list;watch;create;update;patch;delete
10+
// ReplicaSet permissions - controller lists rollout history to retain referenced generated configmaps
11+
//+kubebuilder:rbac:groups=apps,resources=replicasets,verbs=get;list;watch
1012

1113
// Service permissions - controller creates and manages services
1214
//+kubebuilder:rbac:groups="",resources=services,verbs=get;list;watch;create;update;patch;delete

release/operator-openshift.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6922,6 +6922,14 @@ rules:
69226922
- patch
69236923
- update
69246924
- watch
6925+
- apiGroups:
6926+
- apps
6927+
resources:
6928+
- replicasets
6929+
verbs:
6930+
- get
6931+
- list
6932+
- watch
69256933
- apiGroups:
69266934
- autoscaling
69276935
resources:

release/operator.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6923,6 +6923,14 @@ rules:
69236923
- patch
69246924
- update
69256925
- watch
6926+
- apiGroups:
6927+
- apps
6928+
resources:
6929+
- replicasets
6930+
verbs:
6931+
- get
6932+
- list
6933+
- watch
69266934
- apiGroups:
69276935
- autoscaling
69286936
resources:

0 commit comments

Comments
 (0)