Skip to content

Commit 74658c1

Browse files
cdoernclaude
andauthored
fix(ci): publish ogx-client-typescript on release-1.2.x (backport #6301) (#6302)
## Summary Backport of #6301 to `release-1.2.x`, enabling the TypeScript client in the release publish pipeline now that `ogx-ai/ogx-client-typescript` has a matching `release-1.2.x` branch. `release-1.2.x` needed **three** edits (one more than #6301 on main, whose publish-matrix entry was already live): 1. Remove the build `should-build` TEMPORARY skip for `ogx-client-typescript`. 2. **Restore the `ogx-client-typescript` entry in the publish matrix** — it was still commented out here; #6300 only restored the *build* matrix entry (to fix actionlint). 3. Remove the publish `should-publish` TEMPORARY skip. ## Effect With this on `release-1.2.x`, a `packages: all` (default) or `clients-only` release run builds **and** publishes `ogx-client-typescript` to npm, alongside the Python packages. A 1.2.1 cut will then include the TS client. ## Test plan - `actionlint` pre-commit hook passes on the edited `pypi.yml`. - The npm build/publish path is exercised on the next release run. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Charlie Doern <cdoern@redhat.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
1 parent daabe1a commit 74658c1

1 file changed

Lines changed: 5 additions & 14 deletions

File tree

.github/workflows/pypi.yml

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -244,11 +244,7 @@ jobs:
244244
PACKAGE="${{ matrix.package }}"
245245
TYPE="${{ matrix.type }}"
246246
247-
# TEMPORARY: skip ogx-client-typescript until external repo has release branch
248-
if [ "$PACKAGE" == "ogx-client-typescript" ]; then
249-
echo "skip=true" >> "$GITHUB_OUTPUT"
250-
echo "::notice::Skipping $PACKAGE (temporarily disabled)"
251-
elif [ "$PACKAGES" == "all" ]; then
247+
if [ "$PACKAGES" == "all" ]; then
252248
echo "skip=false" >> "$GITHUB_OUTPUT"
253249
elif [ "$PACKAGES" == "ogx-only" ] && { [ "$TYPE" == "local" ] || [ "$TYPE" == "openapi-sdk" ]; }; then
254250
echo "skip=false" >> "$GITHUB_OUTPUT"
@@ -767,10 +763,9 @@ jobs:
767763
matrix:
768764
include:
769765
# Order matters! Dependencies are published first
770-
# TEMPORARY: ogx-client-typescript disabled until external repo has release-1.2.x branch
771-
# - package: ogx-client-typescript
772-
# registry: npm
773-
# type: external
766+
- package: ogx-client-typescript
767+
registry: npm
768+
type: external
774769
- package: ogx-client
775770
registry: pypi
776771
type: openapi-sdk
@@ -790,11 +785,7 @@ jobs:
790785
PACKAGE="${{ matrix.package }}"
791786
TYPE="${{ matrix.type }}"
792787
793-
# TEMPORARY: skip ogx-client-typescript until external repo has release branch
794-
if [ "$PACKAGE" == "ogx-client-typescript" ]; then
795-
echo "skip=true" >> "$GITHUB_OUTPUT"
796-
echo "::notice::Skipping publish for $PACKAGE (temporarily disabled)"
797-
elif [ "$PACKAGES" == "all" ]; then
788+
if [ "$PACKAGES" == "all" ]; then
798789
echo "skip=false" >> "$GITHUB_OUTPUT"
799790
elif [ "$PACKAGES" == "ogx-only" ] && { [ "$TYPE" == "local" ] || [ "$TYPE" == "openapi-sdk" ]; }; then
800791
echo "skip=false" >> "$GITHUB_OUTPUT"

0 commit comments

Comments
 (0)