Skip to content

Commit 5b4b3e8

Browse files
committed
Address copilot review comment
#2 (comment)
1 parent fd8c1e4 commit 5b4b3e8

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

facility_management/20824.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -164,10 +164,11 @@ jobs:
164164
- name: Build feedback
165165
if: env.skip_checks != 'true'
166166
env:
167+
RESULT: ${{ steps.check.outputs.result }}
168+
RESULTS: ${{ steps.check.outputs.extracted }}
169+
PASSED: ${{ steps.check.outputs.passed }}
167170
ALLOWED_HUMAN: ${{ steps.depts.outputs.human }}
168171
run: |
169-
RESULT='${{ steps.check.outputs.result }}'
170-
171172
# Differentiated message when the API call itself failed (e.g. 404)
172173
if echo "$RESULT" | grep -q '^error:'; then
173174
FEEDBACK=$(printf "Uh oh! We couldn't fetch your department from CARE.\n\nDetails: %s\n\nMake sure the department URL you submitted is correct and that the department hasn't been deleted. Expected URL format: \`%s/facility/<facility-id>/settings/departments/<department-id>/departments\`" \
@@ -180,16 +181,14 @@ jobs:
180181
exit 0
181182
fi
182183
183-
RESULTS='${{ steps.check.outputs.extracted }}'
184-
185184
# Parse individual results
186185
T1="✗"; T2="✗"; T3="✗"; T4="✗"
187186
[ "$(echo "$RESULTS" | jq -r '.name')" = "true" ] && T1="✓"
188187
[ "$(echo "$RESULTS" | jq -r '.type')" = "true" ] && T2="✓"
189188
[ "$(echo "$RESULTS" | jq -r '.not_system')" = "true" ] && T3="✓"
190189
[ "$(echo "$RESULTS" | jq -r '.creator')" = "true" ] && T4="✓"
191190
192-
if [ "${{ steps.check.outputs.passed }}" = "true" ]; then
191+
if [ "$PASSED" = "true" ]; then
193192
HEADER="Great work! All checks passed. Your department meets all the requirements."
194193
STATUS="success"
195194
else

0 commit comments

Comments
 (0)