Skip to content

Commit 83be542

Browse files
committed
ci: Clean up the check for Node >= 24
1 parent 30b0745 commit 83be542

4 files changed

Lines changed: 17 additions & 6 deletions

File tree

bin/ci-test.sh

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
#!/bin/bash
2+
3+
NODE_MAJOR_VERSION=$(node -v | cut -d'.' -f1 | sed 's/v//')
4+
5+
# Some projects require Node >= 24; skip them altogether.
6+
if [ "$NODE_MAJOR_VERSION" -lt 24 ]; then
7+
FILTER="--filter=!@ohm-js/wasm --filter=!labrat"
8+
else
9+
FILTER=""
10+
fi
11+
12+
pnpm $FILTER -r build && pnpm lint && pnpm $FILTER -r test

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"packageManager": "pnpm@10.10.0",
44
"scripts": {
55
"build": "pnpm -r build",
6-
"ci-test": "pnpm build && pnpm lint && pnpm test",
6+
"ci-test": "bin/ci-test.sh",
77
"format": "prettier --write . && eslint --fix .",
88
"lint": "eslint .",
99
"test": "pnpm -r test"

packages/labrat/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
{
22
"private": true,
3+
"name": "labrat",
34
"type": "module",
45
"scripts": {
5-
"check-node-version": "node -e \"process.exit(parseInt(process.versions.node.split('.')[0]) < 24 ? 1 : 0)\"",
6-
"test": "pnpm run check-node-version && node --test \"**/*.test.ts\" || echo 'Skipping tests: Node 24 required'",
6+
"test": "node --test \"**/*.test.ts\"",
77
"build": "tsc --noEmit"
88
},
99
"devDependencies": {

packages/wasm/package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,10 @@
1010
"dist"
1111
],
1212
"scripts": {
13-
"build": "pnpm run check-node-version && make || echo 'Skipping build: Node >=24 required'",
13+
"build": "make",
1414
"build-and-test": "make && ava test",
15-
"check-node-version": "node -e \"process.exit(parseInt(process.versions.node.split('.')[0]) < 24 ? 1 : 0)\"",
1615
"prepack": "make",
17-
"test": "pnpm run check-node-version && pnpm run build-and-test || echo 'Skipping tests: Node >=24 required'"
16+
"test": "ava test"
1817
},
1918
"type": "module",
2019
"keywords": [],

0 commit comments

Comments
 (0)