Skip to content

Commit 93e9c80

Browse files
committed
crush now correctly sets GLM-5 context size + address potential security issue
1 parent f339ea7 commit 93e9c80

File tree

2 files changed

+14
-51
lines changed

2 files changed

+14
-51
lines changed

.github/workflows/pull-review-crush.yml

Lines changed: 8 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -35,29 +35,24 @@ jobs:
3535
ZAI_API_KEY: ${{ secrets.ZAI_API_KEY }}
3636

3737
steps:
38-
- name: React to comment
39-
run: |
40-
gh api "/repos/${{ github.repository }}/issues/comments/${{ github.event.comment.id }}/reactions" \
41-
-f content='eyes'
42-
4338
- name: Update comment with status
4439
env:
45-
ORIGINAL_BODY: ${{ github.event.comment.body }}
40+
COMMENT_BODY: ${{ github.event.comment.body }}
4641
run: |
42+
gh api "/repos/${{ github.repository }}/issues/comments/${{ github.event.comment.id }}/reactions" \
43+
-f content='eyes'
4744
gh api "/repos/${{ github.repository }}/issues/comments/${{ github.event.comment.id }}" \
4845
-X PATCH \
49-
-f body="${ORIGINAL_BODY}
46+
-f body="${COMMENT_BODY}
5047
5148
---
5249
5350
_AI review [started](${RUN_URL})._"
5451
5552
- name: Detect fast mode
53+
env:
54+
COMMENT_BODY: ${{ github.event.comment.body }}
5655
run: |
57-
COMMENT_BODY=$(cat <<'EOF'
58-
${{ github.event.comment.body }}
59-
EOF
60-
)
6156
if echo "$COMMENT_BODY" | grep -qP '^\s*/crush_fast'; then
6257
echo "FAST_MODE=true" >> "$GITHUB_ENV"
6358
echo "Fast mode enabled — skipping raw review and combine step"
@@ -415,39 +410,12 @@ jobs:
415410
cat > ~/.config/crush/crush.json << 'EOF'
416411
{
417412
"$schema": "https://charm.land/crush.json",
418-
"providers": {
419-
"zai": {
420-
"models": [
421-
{
422-
"id": "glm-5",
423-
"name": "GLM-5",
424-
"context_window": 202752,
425-
"default_max_tokens": 65536
426-
}
427-
]
428-
}
429-
},
430413
"options": {
431-
"context_paths": [
432-
"AGENTS.md",
433-
"CRUSH.md",
434-
"CLAUDE.md",
435-
"README.md"
436-
],
414+
"context_paths": ["AGENTS.md", "CRUSH.md", "CLAUDE.md", "README.md"],
437415
"disable_metrics": true
438416
},
439417
"permissions": {
440-
"allowed_tools": [
441-
"view",
442-
"read",
443-
"ls",
444-
"glob",
445-
"grep",
446-
"fetch",
447-
"agentic_fetch",
448-
"agent",
449-
"todos"
450-
]
418+
"allowed_tools": ["view", "read", "ls", "glob", "grep", "fetch", "agentic_fetch", "agent", "todos"]
451419
}
452420
}
453421
EOF

.github/workflows/pull-review.yml

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -35,29 +35,24 @@ jobs:
3535
ZAI_API_KEY: ${{ secrets.ZAI_API_KEY }}
3636

3737
steps:
38-
- name: React to comment
39-
run: |
40-
gh api "/repos/${{ github.repository }}/issues/comments/${{ github.event.comment.id }}/reactions" \
41-
-f content='eyes'
42-
4338
- name: Update comment with status
4439
env:
45-
ORIGINAL_BODY: ${{ github.event.comment.body }}
40+
COMMENT_BODY: ${{ github.event.comment.body }}
4641
run: |
42+
gh api "/repos/${{ github.repository }}/issues/comments/${{ github.event.comment.id }}/reactions" \
43+
-f content='eyes'
4744
gh api "/repos/${{ github.repository }}/issues/comments/${{ github.event.comment.id }}" \
4845
-X PATCH \
49-
-f body="${ORIGINAL_BODY}
46+
-f body="${COMMENT_BODY}
5047
5148
---
5249
5350
_AI review [started](${RUN_URL})._"
5451
5552
- name: Detect fast mode
53+
env:
54+
COMMENT_BODY: ${{ github.event.comment.body }}
5655
run: |
57-
COMMENT_BODY=$(cat <<'EOF'
58-
${{ github.event.comment.body }}
59-
EOF
60-
)
6156
if echo "$COMMENT_BODY" | grep -qP '^\s*/review_fast'; then
6257
echo "FAST_MODE=true" >> "$GITHUB_ENV"
6358
echo "Fast mode enabled — skipping raw review and combine step"

0 commit comments

Comments
 (0)