fix: PR title missing from crush review context#52
Merged
Conversation
…ckout pr_data.json was written to the working directory but actions/checkout@v4 wipes it clean. The PR body survived because it was saved to /tmp/pr_body.txt, but the title was read directly from the now-deleted pr_data.json. Fix: save the title to /tmp/pr_title.txt (like the body) and read from there. Co-Authored-By: unknown <>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes missing PR title context in the pull-review-crush GitHub Actions workflow by persisting the title across the actions/checkout@v4 step (which cleans the workspace).
Changes:
- Save PR title to
/tmp/pr_title.txtduring the “Get PR details” step. - Read the PR title from
/tmp/pr_title.txtwhen generating the helpful context (instead of readingpr_data.jsonafter checkout).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
pr_data.jsonfile is written to the working directory in the Get PR details step, butactions/checkout@v4wipes the working directory clean before the Generate helpful context step reads from it. The PR body already survived because it was saved to/tmp/pr_body.txt; the title was not given the same treatment, so it silently resolved to an empty string.Fix: save the title to
/tmp/pr_title.txtalongside the body, and read from there after checkout.Review & Testing Checklist for Human
actions/checkout@v4does indeed wipe the workspace (it does by default withclean: true) — this confirms the root cause/crushor/crush_faston a PR and confirm the<pr_title>block in the Actions log is now populatedNotes