Skip to content

Commit 3ad985b

Browse files
authored
Fix: ignore None as default parameter value (#14)
1 parent 420afdb commit 3ad985b

File tree

4 files changed

+11
-3
lines changed

4 files changed

+11
-3
lines changed

Makefile

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,11 @@ build:
66
publish:
77
twine upload dist/*
88

9+
jenkins-docker:
10+
docker build --pull -t jenkins-test atest/docker
11+
docker run --rm -p 127.0.0.1:8080:8080 -e JAVA_OPTS=-Djenkins.install.runSetupWizard=false -d jenkins-test
12+
913
test:
1014
robot --loglevel DEBUG --pythonpath src/ atest/
1115

16+
test-docker: jenkins-docker test

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[![Build Status](https://travis-ci.org/okgolove/robotframework-jenkins.svg?branch=master)](https://travis-ci.org/okgolove/robotframework-jenkins)
22
[![PyPI version](https://badge.fury.io/py/robotframework-jenkins.svg)](https://badge.fury.io/py/robotframework-jenkins)
3-
![Supported Jenkins Version](https://img.shields.io/badge/jenkins-%3C%3D2.176.1-blue)
3+
![Supported Jenkins Version](https://img.shields.io/badge/Tested%20with%20jenkins-%3E2.176.1%20%3C2.234-blue)
44

55
JenkinsLibrary for Robot Framework
66
==============================

src/JenkinsLibrary/server.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,9 @@ def get_job_parameters(self, name):
145145
'name': param['name'],
146146
'description': param['description'],
147147
'type': param['type'],
148-
'value': param['defaultParameterValue']['value']
148+
# TODO: Add testcase with filepath parameter in a job
149+
'value': param['defaultParameterValue'] if \
150+
param['defaultParameterValue'] is None else \
151+
param['defaultParameterValue'].get('value', None)
149152
})
150153
return params

src/JenkinsLibrary/version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
VERSION = '2.0.0'
1+
VERSION = '2.0.1'

0 commit comments

Comments
 (0)